Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Only use foreground deletion for specific APIGroups #65

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

timebertt
Copy link
Contributor

How to categorize this PR?

/area usability
/kind bug
/priority blocker

What this PR does / why we need it:
With this PR, only resources in API groups apps, extensions and batch are deleted with foreground deletion propagation to workaround kubernetes/kubernetes#91287.

Which issue(s) this PR fixes:
Fixes #64

Special notes for your reviewer:

Release note:

Fixed a bug, that caused the deletion of Services to be blocked.

@timebertt timebertt requested a review from a team as a code owner June 23, 2020 11:45
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug priority/blocker Needs to be resolved now, because it breaks the service labels Jun 23, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 23, 2020
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 23, 2020
@rfranzke rfranzke merged commit 08b86a7 into gardener-attic:master Jun 23, 2020
@timebertt timebertt deleted the fix/foreground-deletion branch July 3, 2020 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/blocker Needs to be resolved now, because it breaks the service reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services deletion blocked
5 participants