Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Configuration for whether resources should be always updated #70

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Configuration for whether resources should be always updated #70

merged 1 commit into from
Jul 3, 2020

Conversation

rfranzke
Copy link
Contributor

@rfranzke rfranzke commented Jul 3, 2020 •
edited by timebertt

How to categorize this PR?

/area usability
/kind enhancement
/priority normal

What this PR does / why we need it:
This PR introduces a new command line parameter --always-update which defaults to false. If set to true it will always send a PUT request for managed resources even if it detects that their desired state does not differ from their actual state in the system. This is

Which issue(s) this PR fixes:
Ref gardener/gardener-extension-provider-aws#134

Special notes for your reviewer:
/invite @tim-ebert

Release note:

The new `--always-update` command line parameter (default: `false`) allows to configure whether to always send a `PUT` request for managed resources regardless of whether their desired state differs from their actual state.

@rfranzke rfranzke requested a review from a team as a code owner July 3, 2020 06:53
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/review Needs review priority/normal labels Jul 3, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 3, 2020
timebertt
timebertt approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 3, 2020
@timebertt timebertt merged commit 4ba1ca1 into gardener-attic:master Jul 3, 2020
@rfranzke rfranzke deleted the feature/always-update branch July 3, 2020 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfranzke @timebertt @gardener-robot-ci-3 @gardener-robot