Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ensures the selectors for deployments used by DWD abide to the Gardener Extension concept #42

Closed
ashwani2k opened this issue Mar 8, 2022 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@ashwani2k
Copy link
Contributor

Feature (What you would like to be added):
With GEP-01 (extensibility) cloudprovider specific details are extracted to extensions.
With the introduction of scaleRef dependencies in the release v0.7.0. The component model of gardener/gardener is broken as it requires it to have knowledge of machine-controller-manager deployment name. Details can be checked here.

As currently its resolved by adding a constant in the g/g api types to identify MCMDeploymentName as design with an alternate selection criteria will require a re-design of concepts which the basic functionality of DWD relies on.

Motivation (Why is this needed?):
To ensure we don't break the contract and keep the separation of concern design principle in play.

Approach/Hint to the implement solution (optional):

@ialidzhikov
Copy link
Member

Let's close for now as currently I don't know of a provider extension that does not use MCM currently. If there is one in the future, we could think of a approach similar the logging extensibility where provider extensions provide a ConfigMap (filters, parsers) with a well-known label and these ConfigMaps are aggregated and passed to the fluent-bit on Seed bootstrap. Let's for now do not introduce such complexity when there is no real need for it.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

3 participants