Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance external link validation #318

Open
Kostov6 opened this issue Apr 9, 2024 · 0 comments
Open

Enhance external link validation #318

Kostov6 opened this issue Apr 9, 2024 · 0 comments
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)

Comments

@Kostov6
Copy link
Contributor

Kostov6 commented Apr 9, 2024

What would you like to be added:
Right now just a single HTTP HEAD request is send to validate an external link. In some cases this could not be enough and a more complex procedure would be required.

Also the whole link validation logic should be reviewed. Right now it seems we have a best effort approach - validation code was added to solve some specific problem at a given time in the past without having a test that defined the case. This leaves some logic that seems to be random like the Retry-After response header with the comment // support only value in seconds <= 5 min .
Because of this questions arise:

  1. How do we handle request taking unexpectedly long to finish? By using expiring contexts?
  2. How do we handle context cancelation or receiving connection error in general?
  3. It is observed that Retrying request! could happen but does it provide any value and if so when?
  4. What about the Retry-After header?

Do we search for a standard link validation procedure and implement it or do we stick with a best effort covering questionable scenarios? Without deciding on a direction enhancing link validation could not proceed.

How to categorize this?:

/kind enhancement
/priority 3

@Kostov6 Kostov6 added the kind/enhancement Enhancement, improvement, extension label Apr 9, 2024
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Apr 9, 2024
@JordanJordanov JordanJordanov added priority/2 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants