Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ability to copy backups between backup buckets #356

Closed
plkokanov opened this issue Jul 6, 2021 · 1 comment · Fixed by #369
Closed

[Feature] Add ability to copy backups between backup buckets #356

plkokanov opened this issue Jul 6, 2021 · 1 comment · Fixed by #369
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@plkokanov
Copy link
Contributor

Feature (What you would like to be added):
As part of the [Control Plane Migration] topic(https://github.com/gardener/gardener/blob/c00ec60c8423d5b95598e7a764d67f366f8c06b6/docs/proposals/07-shoot-control-plane-migration.md) (note that this is the revised GEP) we would like to add the functionality to copy shoot ETCD backups between seed backup buckets.

Motivation (Why is this needed?):
Currently, when a shoot cluster is migrated to a new seed, its backup is kept in the old seed's backup bucket. This means that seeds can have access to backup buckets which do not belong to them and also means that seeds can have BackupEntries which point to BackupBuckets of other seeds.

Approach/Hint to the implement solution (optional):
There is already a ready POC which was outlined in this issue: gardener/gardener#3875 and largely developed in this repo https://github.com/stoyanr/etcd-backup-restore/tree/cpm-poc/master

The plan is to first develop the backup copying as part of the Control Plane Migration "good case scenario" and only later on add functionality for "owner detection" which will be necessary for the "bad case scenario".

@plkokanov plkokanov added the kind/enhancement Enhancement, improvement, extension label Jul 6, 2021
@plkokanov
Copy link
Contributor Author

plkokanov commented Jul 6, 2021

/assign @plkokanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
2 participants