Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe-guard against wrongly mounted volumes #466

Closed
abdasgupta opened this issue Apr 13, 2022 · 3 comments
Closed

Safe-guard against wrongly mounted volumes #466

abdasgupta opened this issue Apr 13, 2022 · 3 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)

Comments

@abdasgupta
Copy link
Contributor

abdasgupta commented Apr 13, 2022

Describe the bug:
We found that there is a bug in csi-driver that can try to attempt to attach two disks to the same node at same time. And so, a race condition may happen and one node may be attached with a volume that is not intended for it. So, it's possible that volume used by ETCD of one shoot is mounted as volume used for ETCD of another shoot. We need to place a check in ETCD backup-restore, so that if this unfortunate mount happens, ETCD BR will not start at all

Expected behavior:
ETCD BR will not start ETCD and throw error if volume of any other shoot is mounted as ETCD volume.

How To Reproduce (as minimally and precisely as possible):

Logs:

Screenshots (if applicable):

Environment (please complete the following information):

  • Etcd version/commit ID :
  • Etcd-backup-restore version/commit ID:
  • Cloud Provider [All/AWS/GCS/ABS/Swift/OSS]:

Anything else we need to know?:

@abdasgupta abdasgupta added the kind/bug Bug label Apr 13, 2022
@gardener-robot
Copy link

@abdasgupta You have mentioned internal references in the public. Please check.

@abdasgupta abdasgupta self-assigned this Apr 13, 2022
@vlerenc
Copy link
Member

vlerenc commented Apr 13, 2022

Thank you @abdasgupta, though I wouldn't call it a bug, but actually a safe-guard/protection, if that ever happens (the bug is with Kubernetes/CSI that leads to such cases of wrongly mounted volumes against which we want a safe-guard as the consequences would be dire).
/title Safe-guard against wrongly mounted volumes
/remove bug
/add enhancement

@gardener-robot gardener-robot changed the title [BUG] Volume containing the ETCD data of different shoot is mounted on one shoot Safe-guard against wrongly mounted volumes Apr 13, 2022
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension and removed kind/bug Bug labels Apr 13, 2022
@gardener gardener deleted a comment from gardener-robot Apr 13, 2022
@ishan16696
Copy link
Member

closing this issue as it is fixed in this PR #468 for master branch
/close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

4 participants