Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions #165

Closed
Tracked by #107
amshuman-kr opened this issue Apr 29, 2021 · 0 comments · Fixed by #250
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) release/beta Planned for Beta release of the Feature
Milestone

Comments

@amshuman-kr
Copy link
Collaborator

amshuman-kr commented Apr 29, 2021

Feature (What you would like to be added):

Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions.

Motivation (Why is this needed?):

Pick individually executable pieces of the multi-node proposal.

Approach/Hint to the implement solution (optional):

The deployment of PodDisruptionBudget resource is probably best done in the main controller and the dynamic modification of the resource based on the Etcd resource status is best done in the custodian controller.

It is probably better to deploy the PodDisruptionBudget only for the multi-node case (spec.replicas > 1) because deploying it for the single-node case might block node drain.

@amshuman-kr amshuman-kr added the kind/enhancement Enhancement, improvement, extension label Apr 29, 2021
@amshuman-kr amshuman-kr added this to the v0.7.0 milestone Apr 29, 2021
@amshuman-kr amshuman-kr changed the title [Feature] Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions. [Feature] Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions Apr 29, 2021
@amshuman-kr amshuman-kr changed the title [Feature] Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions [Feature] Deploy/maintain the correct PodDisruptionBudget configuration according to the Etcd resource status conditions Apr 29, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Dec 5, 2021
@ashwani2k ashwani2k added the release/beta Planned for Beta release of the Feature label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) release/beta Planned for Beta release of the Feature
Projects
None yet
3 participants