Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] The latest snapshot info in etcd status #17

Open
georgekuruvillak opened this issue Mar 4, 2020 · 4 comments
Open

[Feature] The latest snapshot info in etcd status #17

georgekuruvillak opened this issue Mar 4, 2020 · 4 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@georgekuruvillak
Copy link
Contributor

Feature (What you would like to be added):
The status in etcd resource does not reflect the current snapshot [full/delta]. Update the etcd resource status to reflect the latest snapshot information.

Motivation (Why is this needed?):
It would help in control plane migration to fetch the latest snapshot for update.
Approach/Hint to the implement solution (optional):

@georgekuruvillak georgekuruvillak added the kind/enhancement Enhancement, improvement, extension label Mar 4, 2020
@georgekuruvillak
Copy link
Contributor Author

@shreyas-s-rao @swapnilgm

@georgekuruvillak georgekuruvillak changed the title [Feature] [Feature] The latest snapshot info in etcd status Mar 6, 2020
@swapnilgm
Copy link

The etcd-backup-restore, restores from latest snapshot and there is no PITR supported. So such requirements should not be there.

But it makes sense, as ab individual project - irrespective of gardener, where case of dynamic snapshot demand, i.e. when snapshot is triggered via API call on etcd-backup-restore server is valid. It makes sense to me, to druid to introduce snapshot resource, on creation of which druid will call API on etcd-backup-restore to take dynamic snapshot. Currently that call is synchronous and only returns error in case anything goes wrong. We should modify this to return the snapshot metadata. This could be preserved in snapshot resource.

@shreyas-s-rao
Copy link
Contributor

In that case, don't we want a separate API to simply expose latest snapshot details? Or is the case that druid will have to take a snapshot in order to get the latest snapshot info?

@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 10, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 10, 2020
@shreyas-s-rao
Copy link
Contributor

Will be solved by #206 , which allows the leading backup sidecar to update its snapshot info (LastSnapshot, SnapshotType, LastRevision, Timestamp, SnapshotStatus) as part of the EtcdMember status or the EtcdMemberState spec, discussion for which is currently ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

4 participants