Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Prepare Druid for Server-Side Apply #179

Closed
2 tasks
timuthy opened this issue May 21, 2021 · 1 comment
Closed
2 tasks

[Feature] Prepare Druid for Server-Side Apply #179

timuthy opened this issue May 21, 2021 · 1 comment
Assignees
Labels
kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@timuthy
Copy link
Member

timuthy commented May 21, 2021

Feature (What you would like to be added):
Druid should use and support Server-Side Apply where applicable once Gardener dropped the support for seed clusters with K8s <= 1.17 (gardener/gardener#4083).

Motivation (Why is this needed?):
Server-Side Apply makes working with the etcd resource more efficiently when there will be more then one actor (motivated here).

Tasks to be done:

  • Add markers for merge strategy to etcd resource
  • Use SSA for etcd status updates
@timuthy timuthy added the kind/enhancement Enhancement, improvement, extension label May 21, 2021
@timuthy timuthy added this to the v0.7.0 milestone May 21, 2021
@shreyas-s-rao shreyas-s-rao self-assigned this Jul 7, 2021
@timuthy
Copy link
Member Author

timuthy commented Jul 20, 2021

We experienced some major issues with SSA in our controllers:

  • x-kubernetes-list-map-keys does not work properly with any version < 1.21 (for CRDs) which makes it impossible to use SSA for arrays, e.g. status.conditions.
  • Further issues are mentioned in gardener/gardener#4122

Therefore, we close this issue and will work with alternatives (like #206) to avoid conflict errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants