Add a new configurable field fullSnapshotLeaseUpdateInterval in spec.backup section of Etcd CR
#764
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/usability
gardener-robot-ci-1
added
reviewed/ok-to-test
shreyas-s-rao
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for the PR @anveshreddy18 !
Couple of comments from my side:
- PTAL at the points I have mentioned in Add a new configurable field
fullSnapshotLeaseUpdateIntervalin spec.backup section of Etcd CR #763 (comment) - Please use a PR-built image of etcdbr in this PR (at
charts/images.yaml) so that this PR can be easily tested. You can obtain the PR-built image from the concoursepublishstep from Full snapshot lease update retry on failure etcd-backup-restore#711
gardener-robot-ci-3
added
reviewed/ok-to-test
anveshreddy18
changed the title
fullsnapLeaseUpdateRetryInterval in spec.backup section of Etcd CRfullSnapshotLeaseUpdateInterval in spec.backup section of Etcd CR
|
/hold until PR for #728 gets merged, since that will bring changes in the component model for resources deployed by druid. |
gardener-robot
added
the
reviewed/do-not-merge
…spec.backup section of etcd yaml
anveshreddy18
force-pushed
the
configure/fullsnapshot-lease-update-retry-interval
branch
from
7c4f934
to
fefae40
Compare
gardener-robot
added
size/xs
gardener-robot-ci-2
added
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
What this PR does / why we need it:
This PR adds a new field
fullSnapshotLeaseUpdateIntervalin thespec.backupsection of Etcd yaml and makes necessary changes, which allows to configurefull-snapshot-lease-update-intervalparameter used to configure the interval to retry updating full snapshot lease.full-snapshot-lease-update-intervalto configure the retry interval for updating the full snapshot lease. Adding this newfullSnapshotLeaseUpdateIntervalfield to Etcd CR allows user to control the behaviour of retrying to update full snapshot leaseNote: It will be an optional field, and when not set, backup-restore takes care of setting a default value to it.
Which issue(s) this PR fixes:
Fixes #763
Special notes for your reviewer:
Release note: