Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gl-27] Increase docker memorylock limit and install cifs-utils #14

Merged
merged 1 commit into from
Sep 21, 2020
Merged

[gl-27] Increase docker memorylock limit and install cifs-utils #14

merged 1 commit into from
Sep 21, 2020

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Sep 19, 2020 •
edited

How to categorize this PR?

/area os
/kind enhancement
/priority normal
/os garden-linux

What this PR does / why we need it:
A mitigation for Garden linux 27.1 and 27.0 that do:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @ccwienk @hoeltcl @gehoern

Release note:

Docker memory lock limit is increased to 64MB (needed to mitigate https://github.com/golang/go/wiki/LinuxKernelSignalVectorBug) and cifs-utils package is installed (required to enable cifs volumes) on Garden Linux 27.0 and 27.1 nodes. To get this change applied, the shoot owners must trigger rollout of their worker pools.

@gardener-robot gardener-robot added area/os Operation system related kind/enhancement Enhancement, improvement, extension priority/normal labels Sep 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2020
@gardener-robot gardener-robot added the os/garden-linux Related to Garden Linux OS label Sep 19, 2020
@gardener gardener deleted a comment from gardener-robot Sep 19, 2020
@gardener gardener deleted a comment from gardener-robot Sep 19, 2020
@vpnachev vpnachev marked this pull request as ready for review September 19, 2020 18:14
@vpnachev vpnachev requested a review from a team as a code owner September 19, 2020 18:14
@vpnachev
[GL-27.[01]] Install cifs-utils and increase docker memlock limit
388b550 
A mitigation for Garden linux 27.1 and 27.0 that do:
- install cifs-utils from the package registry
- increase the memlock limit for docker containers to mitigate
https://github.com/golang/go/wiki/LinuxKernelSignalVectorBug
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2020
rfranzke
rfranzke approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 21, 2020
@vpnachev vpnachev merged commit 9b4d750 into gardener:master Sep 21, 2020
@vpnachev vpnachev deleted the docker/increase-ulimit branch September 21, 2020 11:40
@vpnachev vpnachev mentioned this pull request Sep 25, 2020
Merged
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
LucaBernstein pushed a commit to LucaBernstein/gardener-extension-os-gardenlinux that referenced this pull request Jun 5, 2024
@vlvasilev
Merge pull request gardener#14 from danielfoehrKn/fix/osc-cri
14d336b 
Fix cloud init generation for CRI containerd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/garden-linux Related to Garden Linux OS reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vpnachev @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot