/
shoot.go
524 lines (451 loc) · 16.6 KB
/
shoot.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
// SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Gardener contributors
//
// SPDX-License-Identifier: Apache-2.0
package mutator
import (
"context"
encodingjson "encoding/json"
"fmt"
"reflect"
extensionswebhook "github.com/gardener/gardener/extensions/pkg/webhook"
corev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
v1beta1constants "github.com/gardener/gardener/pkg/apis/core/v1beta1/constants"
gardencorev1beta1helper "github.com/gardener/gardener/pkg/apis/core/v1beta1/helper"
"github.com/gardener/gardener/pkg/controllerutils"
kutil "github.com/gardener/gardener/pkg/utils/kubernetes"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/equality"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/serializer"
"k8s.io/apimachinery/pkg/runtime/serializer/json"
"k8s.io/utils/ptr"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/manager"
"github.com/gardener/gardener-extension-provider-alicloud/pkg/alicloud"
alicloudclient "github.com/gardener/gardener-extension-provider-alicloud/pkg/alicloud/client"
api "github.com/gardener/gardener-extension-provider-alicloud/pkg/apis/alicloud"
"github.com/gardener/gardener-extension-provider-alicloud/pkg/apis/alicloud/helper"
apisalicloudv1alpha1 "github.com/gardener/gardener-extension-provider-alicloud/pkg/apis/alicloud/v1alpha1"
)
const (
// ShootMutatorName is the shoots mutator webhook name.
ShootMutatorName = "shoots.mutator"
// MutatorPath is the mutator webhook path.
MutatorPath = "/webhooks/mutate"
overlayKey = "overlay"
enabledKey = "enabled"
)
// NewShootMutator returns a new instance of a shoot mutator.
func NewShootMutator(mgr manager.Manager) extensionswebhook.Mutator {
alicloudclientFactory := alicloudclient.NewClientFactory()
return NewShootMutatorWithDeps(mgr, alicloudclientFactory)
}
// NewShootMutatorWithDeps with parameter returns a new instance of a shoot mutator.
func NewShootMutatorWithDeps(mgr manager.Manager, alicloudclientFactory alicloudclient.ClientFactory) extensionswebhook.Mutator {
return &shootMutator{
client: mgr.GetClient(),
apiReader: mgr.GetAPIReader(),
codec: runtime.NewCodec(json.NewSerializerWithOptions(json.DefaultMetaFactory, mgr.GetScheme(), mgr.GetScheme(), json.SerializerOptions{}), serializer.NewCodecFactory(mgr.GetScheme(), serializer.EnableStrict).UniversalDecoder()),
alicloudClientFactory: alicloudclientFactory,
}
}
type shootMutator struct {
client client.Client
apiReader client.Reader
codec runtime.Codec
alicloudClientFactory alicloudclient.ClientFactory
}
func (s *shootMutator) Mutate(ctx context.Context, newObj, oldObj client.Object) error {
shoot, ok := newObj.(*corev1beta1.Shoot)
if !ok {
return fmt.Errorf("wrong object type %T", newObj)
}
// skip validation if it's a workerless Shoot
if gardencorev1beta1helper.IsWorkerless(shoot) {
return nil
}
if shoot.Spec.Networking != nil && shoot.Spec.Networking.Type != nil {
err := s.mutateNetworkOverlay(shoot, oldObj)
if err != nil {
return err
}
}
if oldObj != nil {
oldShoot, ok := oldObj.(*corev1beta1.Shoot)
if !ok {
return fmt.Errorf("wrong object type %T for old object", oldObj)
}
return s.mutateShootUpdate(ctx, shoot, oldShoot)
} else {
return s.mutateShootCreation(ctx, shoot)
}
}
func (s *shootMutator) mutateShootCreation(ctx context.Context, shoot *corev1beta1.Shoot) error {
logger.Info("Starting Shoot Creation Mutation")
err := s.mutateControlPlaneConfigForCreate(shoot)
if err != nil {
return err
}
for _, worker := range shoot.Spec.Provider.Workers {
if err := s.setDefaultForEncryptedDisk(ctx, shoot, &worker); err != nil {
return err
}
}
return nil
}
func (s *shootMutator) mutateNetworkOverlay(shoot *corev1beta1.Shoot, old client.Object) error {
// Skip if shoot is in restore or migration phase
if wasShootRescheduledToNewSeed(shoot) {
return nil
}
var oldShoot *corev1beta1.Shoot
var ok bool
if old != nil {
oldShoot, ok = old.(*corev1beta1.Shoot)
if !ok {
return fmt.Errorf("wrong object type %T", old)
}
}
if oldShoot != nil && isShootInMigrationOrRestorePhase(shoot) {
return nil
}
// Skip if specs are matching
if oldShoot != nil && reflect.DeepEqual(shoot.Spec, oldShoot.Spec) {
return nil
}
// Skip if shoot is in deletion phase
if shoot.DeletionTimestamp != nil || oldShoot != nil && oldShoot.DeletionTimestamp != nil {
return nil
}
if shoot.Spec.Networking != nil {
networkConfig, err := s.decodeNetworkConfig(shoot.Spec.Networking.ProviderConfig)
if err != nil {
return err
}
if oldShoot == nil && networkConfig[overlayKey] == nil {
networkConfig[overlayKey] = map[string]interface{}{enabledKey: false}
}
if oldShoot != nil && networkConfig[overlayKey] == nil {
oldNetworkConfig, err := s.decodeNetworkConfig(oldShoot.Spec.Networking.ProviderConfig)
if err != nil {
return err
}
if oldNetworkConfig[overlayKey] != nil {
networkConfig[overlayKey] = oldNetworkConfig[overlayKey]
}
}
if *shoot.Spec.Networking.Type == "calico" {
if overlay, ok := networkConfig[overlayKey].(map[string]interface{}); ok {
if !overlay[enabledKey].(bool) {
networkConfig["snatToUpstreamDNS"] = map[string]interface{}{enabledKey: false}
}
}
}
modifiedJSON, err := encodingjson.Marshal(networkConfig)
if err != nil {
return err
}
shoot.Spec.Networking.ProviderConfig = &runtime.RawExtension{
Raw: modifiedJSON,
}
}
return nil
}
func (s *shootMutator) decodeNetworkConfig(network *runtime.RawExtension) (map[string]interface{}, error) {
var networkConfig map[string]interface{}
if network == nil || network.Raw == nil {
return map[string]interface{}{}, nil
}
if err := encodingjson.Unmarshal(network.Raw, &networkConfig); err != nil {
return nil, err
}
return networkConfig, nil
}
func (s *shootMutator) setDefaultForEncryptedDisk(ctx context.Context, shoot *corev1beta1.Shoot, worker *corev1beta1.Worker) error {
imageName := worker.Machine.Image.Name
imageVersion := worker.Machine.Image.Version
logger.Info("Check ImageName: " + imageName + "; ImageVesion: " + *imageVersion)
if worker.DataVolumes != nil {
for i := range worker.DataVolumes {
volume := &worker.DataVolumes[i]
if volume.Encrypted == nil {
logger.Info("Set encrypted disk by default for data disk")
volume.Encrypted = ptr.To(true)
}
}
}
if worker.Volume != nil && worker.Volume.Encrypted == nil {
//don't set encrypted disk by default if image is system image
isCustomizeImage, err := s.isCustomizedImage(ctx, shoot, imageName, imageVersion)
if err != nil {
return err
}
if !isCustomizeImage {
return nil
}
logger.Info("Customized Image is used and we set encrypted disk by default for system disk")
worker.Volume.Encrypted = ptr.To(true)
}
return nil
}
func (s *shootMutator) isCustomizedImage(ctx context.Context, shoot *corev1beta1.Shoot, imageName string, imageVersion *string) (bool, error) {
cloudProfile := shoot.Spec.CloudProfileName
region := shoot.Spec.Region
logger.Info("Checking in cloudProfie", "CloudProfile", cloudProfile, "Region", region)
imageId, err := s.getImageId(ctx, imageName, imageVersion, region, cloudProfile)
if err != nil || imageId == "" {
return false, err
}
logger.Info("Got ImageID", "ImageID", imageId)
isOwnedByAli, err := s.isOwnedbyAliCloud(ctx, shoot, imageId, region)
return !isOwnedByAli, err
}
func (s *shootMutator) isOwnedbyAliCloud(ctx context.Context, shoot *corev1beta1.Shoot, imageId string, region string) (bool, error) {
var (
secretBinding = &corev1beta1.SecretBinding{}
)
if shoot.Spec.SecretBindingName == nil {
return false, fmt.Errorf("secretBindingName can't be nil")
}
secretBindingKey := kutil.Key(shoot.Namespace, *shoot.Spec.SecretBindingName)
if err := kutil.LookupObject(ctx, s.client, s.apiReader, secretBindingKey, secretBinding); err != nil {
return false, err
}
var (
secret = &corev1.Secret{}
secretRef = secretBinding.SecretRef.Name
secretKey = kutil.Key(secretBinding.SecretRef.Namespace, secretRef)
)
if err := s.apiReader.Get(ctx, secretKey, secret); err != nil {
return false, err
}
accessKeyID, ok := secret.Data[alicloud.AccessKeyID]
if !ok {
return false, fmt.Errorf("missing %q field in secret %s", alicloud.AccessKeyID, secretRef)
}
accessKeySecret, ok := secret.Data[alicloud.AccessKeySecret]
if !ok {
return false, fmt.Errorf("missing %q field in secret %s", alicloud.AccessKeySecret, secretRef)
}
shootECSClient, err := s.alicloudClientFactory.NewECSClient(region, string(accessKeyID), string(accessKeySecret))
if err != nil {
return false, err
}
if exist, err := shootECSClient.CheckIfImageExists(imageId); err != nil {
return false, err
} else if exist {
return shootECSClient.CheckIfImageOwnedByAliCloud(imageId)
}
return false, nil
}
func (s *shootMutator) getImageId(ctx context.Context, imageName string, imageVersion *string, imageRegion string, cloudProfileName string) (string, error) {
var (
cloudProfile = &corev1beta1.CloudProfile{}
cloudProfileKey = kutil.Key(cloudProfileName)
)
if err := kutil.LookupObject(ctx, s.client, s.apiReader, cloudProfileKey, cloudProfile); err != nil {
return "", err
}
cloudProfileConfig, err := s.getCloudProfileConfig(cloudProfile)
if err != nil {
return "", err
}
return helper.FindImageForRegionFromCloudProfile(cloudProfileConfig, imageName, *imageVersion, imageRegion)
}
func (s *shootMutator) getCloudProfileConfig(cloudProfile *corev1beta1.CloudProfile) (*api.CloudProfileConfig, error) {
var cloudProfileConfig = &api.CloudProfileConfig{}
if _, _, err := s.codec.Decode(cloudProfile.Spec.ProviderConfig.Raw, nil, cloudProfileConfig); err != nil {
return nil, fmt.Errorf("could not decode providerConfig of cloudProfile for '%s': %w", kutil.ObjectName(cloudProfile), err)
}
return cloudProfileConfig, nil
}
func (s *shootMutator) mutateShootUpdate(ctx context.Context, shoot, oldShoot *corev1beta1.Shoot) error {
if !equality.Semantic.DeepEqual(shoot.Spec, oldShoot.Spec) {
if err := s.mutateControlPlaneConfigForUpdate(shoot, oldShoot); err != nil {
return err
}
if err := s.triggerInfraUpdateForNewEncryptedSystemDisk(ctx, shoot, oldShoot); err != nil {
return err
}
}
if !equality.Semantic.DeepEqual(shoot.Spec, oldShoot.Spec) {
s.mutateForEncryptedSystemDiskChange(shoot, oldShoot)
}
return nil
}
func (s *shootMutator) triggerInfraUpdateForNewEncryptedSystemDisk(ctx context.Context, shoot, oldshoot *corev1beta1.Shoot) error {
for _, worker := range shoot.Spec.Provider.Workers {
oldWorker := getWorkerByName(oldshoot, worker.Name)
if oldWorker == nil {
logger.Info("Set default value of encrypted disk for newly added worker")
if err := s.setDefaultForEncryptedDisk(ctx, shoot, &worker); err != nil {
return err
}
continue
}
if worker.Volume != nil && worker.Volume.Encrypted == nil && oldWorker.Volume != nil && oldWorker.Volume.Encrypted != nil {
logger.Info("Encrypted disk flag for system disk is not set, keep old value")
worker.Volume.Encrypted = oldWorker.Volume.Encrypted
}
oldDataVolumes := oldWorker.DataVolumes
for i := range worker.DataVolumes {
dataVolume := &worker.DataVolumes[i]
oldDataVolume := getVolumeByName(oldDataVolumes, dataVolume.Name)
if oldDataVolume == nil {
if dataVolume.Encrypted == nil {
logger.Info("Set encrypted disk by default for newly added data disk")
dataVolume.Encrypted = ptr.To(true)
}
continue
}
if dataVolume.Encrypted == nil && oldDataVolume.Encrypted != nil {
logger.Info("Encrypted disk flag for data disk is not set, keep old value")
dataVolume.Encrypted = oldDataVolume.Encrypted
}
}
}
return nil
}
func getWorkerByName(shoot *corev1beta1.Shoot, workerName string) *corev1beta1.Worker {
for _, worker := range shoot.Spec.Provider.Workers {
if worker.Name == workerName {
return &worker
}
}
return nil
}
func getVolumeByName(dataVolumes []corev1beta1.DataVolume, volumeName string) *corev1beta1.DataVolume {
if dataVolumes == nil {
return nil
}
for _, volume := range dataVolumes {
if volume.Name == volumeName {
return &volume
}
}
return nil
}
func (s *shootMutator) mutateForEncryptedSystemDiskChange(shoot, oldShoot *corev1beta1.Shoot) {
if requireNewEncryptedImage(shoot.Spec.Provider.Workers, oldShoot.Spec.Provider.Workers) {
logger.Info("Need to reconcile infra as new encrypted system disk found in workers", "name", shoot.Name, "namespace", shoot.Namespace)
if shoot.Annotations == nil {
shoot.Annotations = make(map[string]string)
}
controllerutils.AddTasks(shoot.Annotations, v1beta1constants.ShootTaskDeployInfrastructure)
}
}
// Check encrypted flag in new workers' volumes. If it is changed to be true, check for old workers
// if there is already a volume is set to be encrypted and also the OS version is the same.
func requireNewEncryptedImage(newWorkers, oldWorkers []corev1beta1.Worker) bool {
var imagesEncrypted []*corev1beta1.ShootMachineImage
for _, w := range oldWorkers {
if w.Volume != nil && w.Volume.Encrypted != nil && *w.Volume.Encrypted {
if w.Machine.Image != nil {
imagesEncrypted = append(imagesEncrypted, w.Machine.Image)
}
}
}
for _, w := range newWorkers {
if w.Volume != nil && w.Volume.Encrypted != nil && *w.Volume.Encrypted {
if w.Machine.Image != nil {
found := false
for _, image := range imagesEncrypted {
if w.Machine.Image.Name == image.Name && reflect.DeepEqual(w.Machine.Image.Version, image.Version) {
found = true
break
}
}
if !found {
return true
}
}
}
}
return false
}
func (s *shootMutator) decodeControlPlaneConfig(provider *corev1beta1.Provider) (*apisalicloudv1alpha1.ControlPlaneConfig, error) {
cpConfig := &apisalicloudv1alpha1.ControlPlaneConfig{}
if provider.ControlPlaneConfig != nil {
if _, _, err := s.codec.Decode(provider.ControlPlaneConfig.Raw, nil, cpConfig); err != nil {
return nil, fmt.Errorf("could not decode providerConfig of controlplane: %w", err)
}
}
return cpConfig, nil
}
func (s *shootMutator) convertToRawExtension(obj runtime.Object) (*runtime.RawExtension, error) {
if obj == nil {
return nil, nil
}
data, err := runtime.Encode(s.codec, obj)
if err != nil {
return nil, err
}
return &runtime.RawExtension{
Raw: data,
}, nil
}
func (s *shootMutator) mutateControlPlaneConfigForCreate(shoot *corev1beta1.Shoot) error {
cpConfig, err := s.decodeControlPlaneConfig(&shoot.Spec.Provider)
if err != nil {
return err
}
if cpConfig.CSI == nil {
cpConfig.CSI = &apisalicloudv1alpha1.CSI{
EnableADController: ptr.To(true),
}
} else {
if cpConfig.CSI.EnableADController == nil {
cpConfig.CSI.EnableADController = ptr.To(true)
}
}
raw, err := s.convertToRawExtension(cpConfig)
if err != nil {
return err
}
shoot.Spec.Provider.ControlPlaneConfig = raw
return nil
}
func (s *shootMutator) mutateControlPlaneConfigForUpdate(newShoot, oldShoot *corev1beta1.Shoot) error {
oldCPConfig, err := s.decodeControlPlaneConfig(&oldShoot.Spec.Provider)
if err != nil {
return err
}
newCPConfig, err := s.decodeControlPlaneConfig(&newShoot.Spec.Provider)
if err != nil {
return err
}
changed := false
// If EnableADController in new shoot is nil, keep the old value
if oldCPConfig.CSI != nil {
if newCPConfig.CSI == nil {
newCPConfig.CSI = &apisalicloudv1alpha1.CSI{EnableADController: oldCPConfig.CSI.EnableADController}
changed = true
} else if newCPConfig.CSI.EnableADController == nil {
newCPConfig.CSI.EnableADController = oldCPConfig.CSI.EnableADController
changed = true
}
}
if changed {
raw, err := s.convertToRawExtension(newCPConfig)
if err != nil {
return err
}
newShoot.Spec.Provider.ControlPlaneConfig = raw
}
return nil
}
// wasShootRescheduledToNewSeed returns true if the shoot.Spec.SeedName has been changed, but the migration operation has not started yet.
func wasShootRescheduledToNewSeed(shoot *corev1beta1.Shoot) bool {
return shoot.Status.LastOperation != nil &&
shoot.Status.LastOperation.Type != corev1beta1.LastOperationTypeMigrate &&
shoot.Spec.SeedName != nil &&
shoot.Status.SeedName != nil &&
*shoot.Spec.SeedName != *shoot.Status.SeedName
}
// isShootInMigrationOrRestorePhase returns true if the shoot is currently being migrated or restored.
func isShootInMigrationOrRestorePhase(shoot *corev1beta1.Shoot) bool {
return shoot.Status.LastOperation != nil &&
(shoot.Status.LastOperation.Type == corev1beta1.LastOperationTypeRestore &&
shoot.Status.LastOperation.State != corev1beta1.LastOperationStateSucceeded ||
shoot.Status.LastOperation.Type == corev1beta1.LastOperationTypeMigrate)
}