Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate shoot/seed conditions #35

Open
wyb1 opened this issue Aug 6, 2020 · 0 comments
Open

Handle duplicate shoot/seed conditions #35

wyb1 opened this issue Aug 6, 2020 · 0 comments
Assignees
Labels
kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@wyb1
Copy link
Contributor

wyb1 commented Aug 6, 2020

What happened:
If a shoot or seed has duplicate conditions, the gardener-metrics-exporter will error and not expose any metrics.
For example if a shoot has the following status the gme will not be able to expose any metrics.

status:
  conditions:
  - lastTransitionTime: "2020-08-06T04:09:26Z"
    lastUpdateTime: "2020-08-06T08:56:29Z"
    message: API server /healthz endpoint responded with success status code. [response_time:2ms]
    reason: HealthzRequestSucceeded
    status: "True"
    type: APIServerAvailable
  - lastTransitionTime: "2020-08-06T04:09:26Z"
    lastUpdateTime: "2020-08-06T08:56:29Z"
    message: All control plane components are healthy.
    reason: ControlPlaneRunning
    status: "True"
    type: ControlPlaneHealthy
  - lastTransitionTime: "2020-08-06T04:09:26Z"
    lastUpdateTime: "2020-08-06T08:56:29Z"
    message: Every node registered to the cluster is ready.
    reason: EveryNodeReady
    status: "True"
    type: EveryNodeReady
  - lastTransitionTime: "2020-08-06T06:55:55Z"
    lastUpdateTime: "2020-08-06T08:56:29Z"
    message: All system components are healthy.
    reason: SystemComponentsRunning
    status: "True"
    type: SystemComponentsHealthy
  - lastTransitionTime: "2020-08-05T14:13:10Z"
    lastUpdateTime: "2020-08-05T14:13:10Z"
    message: Gardenlet is posting ready status.
    reason: GardenletReady
    status: "True"
    type: GardenletReady
  - lastTransitionTime: null
    lastUpdateTime: null
    message: ""
    reason: ""
    status: ""
    type: ""
  - lastTransitionTime: null
    lastUpdateTime: null
    message: ""
    reason: ""
    status: ""
    type: ""

In the example above there are two duplicate conditions that contain no data.
What you expected to happen:
Regardless of how duplicate conditions got there, the gme should be able to handle this without having an error. It could skip this metric and log an error instead of not exposing metrics.

How to reproduce it (as minimally and precisely as possible):
Add two duplicate conditions to a shoot/seed.

@wyb1 wyb1 added the kind/bug Bug label Aug 6, 2020
@wyb1 wyb1 self-assigned this Aug 6, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 6, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants