/
shoot_maintenance_control.go
402 lines (342 loc) · 18.4 KB
/
shoot_maintenance_control.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
// Copyright (c) 2018 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package shoot
import (
"context"
"fmt"
"strconv"
"time"
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
v1beta1constants "github.com/gardener/gardener/pkg/apis/core/v1beta1/constants"
gardencorev1beta1helper "github.com/gardener/gardener/pkg/apis/core/v1beta1/helper"
"github.com/gardener/gardener/pkg/client/kubernetes"
"github.com/gardener/gardener/pkg/controllermanager/apis/config"
"github.com/gardener/gardener/pkg/controllerutils"
"github.com/gardener/gardener/pkg/logger"
"github.com/gardener/gardener/pkg/utils"
gutil "github.com/gardener/gardener/pkg/utils/gardener"
kutil "github.com/gardener/gardener/pkg/utils/kubernetes"
"github.com/Masterminds/semver"
"github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
apiequality "k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/retry"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)
func (c *Controller) shootMaintenanceAdd(obj interface{}) {
key, err := cache.MetaNamespaceKeyFunc(obj)
if err != nil {
return
}
c.shootMaintenanceQueue.Add(key)
}
func (c *Controller) shootMaintenanceUpdate(oldObj, newObj interface{}) {
newShoot, ok1 := newObj.(*gardencorev1beta1.Shoot)
oldShoot, ok2 := oldObj.(*gardencorev1beta1.Shoot)
if !ok1 || !ok2 {
return
}
if hasMaintainNowAnnotation(newShoot) || !apiequality.Semantic.DeepEqual(oldShoot.Spec.Maintenance.TimeWindow, newShoot.Spec.Maintenance.TimeWindow) {
c.shootMaintenanceAdd(newObj)
}
}
func (c *Controller) shootMaintenanceDelete(obj interface{}) {
shoot, ok := obj.(*gardencorev1beta1.Shoot)
if shoot == nil || !ok {
return
}
key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
if err != nil {
return
}
c.shootMaintenanceQueue.Done(key)
}
// NewShootMaintenanceReconciler creates a new instance of a reconciler which maintains Shoots.
func NewShootMaintenanceReconciler(l logrus.FieldLogger, gardenClient kubernetes.Interface, config config.ShootMaintenanceControllerConfiguration, recorder record.EventRecorder) reconcile.Reconciler {
return &shootMaintenanceReconciler{
logger: l,
gardenClient: gardenClient,
config: config,
recorder: recorder,
}
}
type shootMaintenanceReconciler struct {
logger logrus.FieldLogger
gardenClient kubernetes.Interface
config config.ShootMaintenanceControllerConfiguration
recorder record.EventRecorder
}
func (r *shootMaintenanceReconciler) Reconcile(ctx context.Context, request reconcile.Request) (reconcile.Result, error) {
shoot := &gardencorev1beta1.Shoot{}
if err := r.gardenClient.Client().Get(ctx, request.NamespacedName, shoot); err != nil {
if apierrors.IsNotFound(err) {
r.logger.Infof("Object %q is gone, stop reconciling: %v", request.Name, err)
return reconcile.Result{}, nil
}
r.logger.Infof("Unable to retrieve object %q from store: %v", request.Name, err)
return reconcile.Result{}, err
}
if shoot.DeletionTimestamp != nil {
r.logger.Debug("[SHOOT MAINTENANCE] - skipping because Shoot is marked as to be deleted")
return reconcile.Result{}, nil
}
requeueAfter := requeueAfterDuration(shoot)
if !mustMaintainNow(shoot) {
logger.Logger.Infof("[SHOOT MAINTENANCE] %s/%s - skipping because Shoot must not be maintained now.", shoot.Namespace, shoot.Name)
return reconcile.Result{RequeueAfter: requeueAfter}, nil
}
return reconcile.Result{RequeueAfter: requeueAfter}, r.reconcile(ctx, shoot, r.gardenClient)
}
func requeueAfterDuration(shoot *gardencorev1beta1.Shoot) time.Duration {
var (
now = time.Now()
window = gutil.EffectiveShootMaintenanceTimeWindow(shoot)
duration = window.RandomDurationUntilNext(now, false)
nextMaintenance = time.Now().UTC().Add(duration)
)
logger.Logger.Infof("[SHOOT MAINTENANCE] %s/%s - Scheduled maintenance in %s at %s", shoot.Namespace, shoot.Name, duration.Round(time.Minute), nextMaintenance.UTC().Round(time.Minute))
return duration
}
func (r *shootMaintenanceReconciler) reconcile(ctx context.Context, shoot *gardencorev1beta1.Shoot, gardenClient kubernetes.Interface) error {
key := fmt.Sprintf("%s/%s", shoot.Namespace, shoot.Name)
shootLogger := r.logger.WithField("shoot", key)
shootLogger.Infof("[SHOOT MAINTENANCE] %s", key)
cloudProfile := &gardencorev1beta1.CloudProfile{}
if err := r.gardenClient.Client().Get(ctx, kutil.Key(shoot.Spec.CloudProfileName), cloudProfile); err != nil {
return err
}
updatedMachineImages, reasonForImageUpdatePerPool, err := MaintainMachineImages(shootLogger, shoot, cloudProfile)
if err != nil {
// continue execution to allow the kubernetes version update
shootLogger.Error(fmt.Sprintf("Could not maintain machine image version: %s", err.Error()))
}
updatedKubernetesVersion, reasonForKubernetesUpdate, err := MaintainKubernetesVersion(shoot, cloudProfile, shootLogger)
if err != nil {
// continue execution to allow the machine image version update
shootLogger.Error(fmt.Sprintf("Could not maintain kubernetes version: %s", err.Error()))
}
// Update the Shoot resource object.
_, err = kutil.TryUpdateShoot(ctx, gardenClient.GardenCore(), retry.DefaultBackoff, shoot.ObjectMeta, func(s *gardencorev1beta1.Shoot) (*gardencorev1beta1.Shoot, error) {
if !apiequality.Semantic.DeepEqual(shoot.Spec.Maintenance.AutoUpdate, s.Spec.Maintenance.AutoUpdate) {
return nil, fmt.Errorf("auto update section of Shoot %s/%s changed mid-air", s.Namespace, s.Name)
}
// do not add reconcile annotation if shoot was once set to failed or if shoot is already in an ongoing reconciliation
if s.Status.LastOperation != nil && s.Status.LastOperation.State == gardencorev1beta1.LastOperationStateSucceeded {
metav1.SetMetaDataAnnotation(&s.ObjectMeta, v1beta1constants.GardenerOperation, v1beta1constants.GardenerOperationReconcile)
}
var needsRetry bool
if val, ok := s.Annotations[v1beta1constants.FailedShootNeedsRetryOperation]; ok {
needsRetry, _ = strconv.ParseBool(val)
}
delete(s.Annotations, v1beta1constants.FailedShootNeedsRetryOperation)
if needsRetry {
metav1.SetMetaDataAnnotation(&s.ObjectMeta, v1beta1constants.GardenerOperation, v1beta1constants.ShootOperationRetry)
}
controllerutils.AddTasks(s.Annotations, v1beta1constants.ShootTaskDeployInfrastructure)
if utils.IsTrue(r.config.EnableShootControlPlaneRestarter) {
controllerutils.AddTasks(s.Annotations, v1beta1constants.ShootTaskRestartControlPlanePods)
}
if utils.IsTrue(r.config.EnableShootCoreAddonRestarter) {
controllerutils.AddTasks(s.Annotations, v1beta1constants.ShootTaskRestartCoreAddons)
}
if updatedMachineImages != nil {
gardencorev1beta1helper.UpdateMachineImages(s.Spec.Provider.Workers, updatedMachineImages)
}
if updatedKubernetesVersion != nil {
s.Spec.Kubernetes.Version = *updatedKubernetesVersion
}
if hasMaintainNowAnnotation(s) {
delete(s.Annotations, v1beta1constants.GardenerOperation)
}
return s, nil
})
if err != nil {
shootLogger.Error(fmt.Sprintf("Could not update the Shoot specification: %s", err.Error()))
return err
}
if updatedKubernetesVersion != nil {
r.recorder.Eventf(shoot, corev1.EventTypeNormal, gardencorev1beta1.ShootEventK8sVersionMaintenance, "%s",
fmt.Sprintf("Updated %s.", *reasonForKubernetesUpdate))
}
if updatedMachineImages != nil {
for _, reason := range reasonForImageUpdatePerPool {
r.recorder.Eventf(shoot, corev1.EventTypeNormal, gardencorev1beta1.ShootEventImageVersionMaintenance, "%s",
fmt.Sprintf("Updated %s.", reason))
}
}
shootLogger.Infof("[SHOOT MAINTENANCE] completed")
return nil
}
// MaintainKubernetesVersion determines if a shoots kubernetes version has to be maintained and in case returns the target version
func MaintainKubernetesVersion(shoot *gardencorev1beta1.Shoot, profile *gardencorev1beta1.CloudProfile, logger *logrus.Entry) (updatedKubernetesVersion *string, messageKubernetesUpdate *string, error error) {
shouldBeUpdated, reason, isExpired, err := shouldKubernetesVersionBeUpdated(shoot, profile)
if err != nil {
return nil, nil, err
}
if shouldBeUpdated {
// get latest version that qualifies for a patch update
newerPatchVersionFound, latestPatchVersion, err := gardencorev1beta1helper.GetKubernetesVersionForPatchUpdate(profile, shoot.Spec.Kubernetes.Version)
if err != nil {
return nil, nil, fmt.Errorf("failure while determining the latest Kubernetes patch version in the CloudProfile: %s", err.Error())
}
if newerPatchVersionFound {
msg := fmt.Sprintf("Kubernetes version '%s' to version '%s'. This is an increase in the patch level. Reason: %s", shoot.Spec.Kubernetes.Version, latestPatchVersion, *reason)
logger.Debugf("[SHOOT MAINTENANCE] Updating %s", msg)
return &latestPatchVersion, &msg, nil
}
// no newer patch version found & is expired -> forcefully update to latest patch of next minor version
if isExpired {
// get latest version that qualifies for a minor update
newMinorAvailable, latestPatchVersionNewMinor, err := gardencorev1beta1helper.GetKubernetesVersionForMinorUpdate(profile, shoot.Spec.Kubernetes.Version)
if err != nil {
return nil, nil, fmt.Errorf("failure while determining newer Kubernetes minor version in the CloudProfile: %s", err.Error())
}
// cannot update as there is no consecutive minor version available (e.g shoot is on 1.16.X, but there is only 1.18.X, available and not 1.17.X)
if !newMinorAvailable {
return nil, nil, fmt.Errorf("cannot perform minor Kubernetes version update for expired Kubernetes version '%s'. No suitable version found in CloudProfile - this is most likely a misconfiguration of the CloudProfile", shoot.Spec.Kubernetes.Version)
}
msg := fmt.Sprintf("Kubernetes version '%s' to version '%s'. This is an increase in the minor level. Reason: %s", shoot.Spec.Kubernetes.Version, latestPatchVersionNewMinor, *reason)
logger.Debugf("[SHOOT MAINTENANCE] Updating %s", msg)
return &latestPatchVersionNewMinor, &msg, nil
}
}
return nil, nil, nil
}
func shouldKubernetesVersionBeUpdated(shoot *gardencorev1beta1.Shoot, profile *gardencorev1beta1.CloudProfile) (shouldBeUpdated bool, reason *string, isExpired bool, error error) {
versionExistsInCloudProfile, version, err := gardencorev1beta1helper.KubernetesVersionExistsInCloudProfile(profile, shoot.Spec.Kubernetes.Version)
if err != nil {
return false, nil, false, err
}
var updateReason string
if !versionExistsInCloudProfile {
updateReason = "Version does not exist in CloudProfile"
return true, &updateReason, true, nil
}
if ExpirationDateExpired(version.ExpirationDate) {
updateReason = "Kubernetes version expired - force update required"
return true, &updateReason, true, nil
}
if shoot.Spec.Maintenance.AutoUpdate.KubernetesVersion {
updateReason = "AutoUpdate of Kubernetes version configured"
return true, &updateReason, false, nil
}
return false, nil, false, nil
}
func mustMaintainNow(shoot *gardencorev1beta1.Shoot) bool {
return hasMaintainNowAnnotation(shoot) || gutil.IsNowInEffectiveShootMaintenanceTimeWindow(shoot)
}
func hasMaintainNowAnnotation(shoot *gardencorev1beta1.Shoot) bool {
operation, ok := shoot.Annotations[v1beta1constants.GardenerOperation]
return ok && operation == v1beta1constants.ShootOperationMaintain
}
// MaintainMachineImages determines if a shoots machine images have to be maintained and in case returns the target images
func MaintainMachineImages(logger *logrus.Entry, shoot *gardencorev1beta1.Shoot, cloudProfile *gardencorev1beta1.CloudProfile) (updatedMachineImages []*gardencorev1beta1.ShootMachineImage, reasons []string, error error) {
var (
shootMachineImagesForUpdate []*gardencorev1beta1.ShootMachineImage
reasonsForUpdate []string
)
for _, worker := range shoot.Spec.Provider.Workers {
workerImage := worker.Machine.Image
machineImageFromCloudProfile, err := determineMachineImage(cloudProfile, workerImage)
if err != nil {
return nil, nil, err
}
shouldBeUpdated, reason, updatedMachineImage, err := shouldMachineImageBeUpdated(logger, shoot.Spec.Maintenance.AutoUpdate.MachineImageVersion, &machineImageFromCloudProfile, workerImage)
if err != nil {
return nil, nil, err
}
if !shouldBeUpdated {
continue
}
message := fmt.Sprintf("image of worker-pool '%s' from '%s' version '%s' to version '%s'. Reason: %s", worker.Name, workerImage.Name, *workerImage.Version, *updatedMachineImage.Version, *reason)
reasonsForUpdate = append(reasonsForUpdate, message)
logger.Debugf("[SHOOT MAINTENANCE] Updating %s", message)
shootMachineImagesForUpdate = append(shootMachineImagesForUpdate, updatedMachineImage)
}
if len(shootMachineImagesForUpdate) == 0 {
return nil, nil, nil
}
return shootMachineImagesForUpdate, reasonsForUpdate, nil
}
func determineMachineImage(cloudProfile *gardencorev1beta1.CloudProfile, shootMachineImage *gardencorev1beta1.ShootMachineImage) (gardencorev1beta1.MachineImage, error) {
machineImagesFound, machineImageFromCloudProfile, err := gardencorev1beta1helper.DetermineMachineImageForName(cloudProfile, shootMachineImage.Name)
if err != nil {
return gardencorev1beta1.MachineImage{}, fmt.Errorf("failure while determining the default machine image in the CloudProfile: %s", err.Error())
}
if !machineImagesFound {
return gardencorev1beta1.MachineImage{}, fmt.Errorf("failure while determining the default machine image in the CloudProfile: no machineImage with name '%s' (specified in shoot) could be found in the cloudProfile '%s'", shootMachineImage.Name, cloudProfile.Name)
}
return machineImageFromCloudProfile, nil
}
// shouldMachineImageBeUpdated determines if a machine image should be updated based on whether it exists in the CloudProfile, auto update applies or a force update is required.
func shouldMachineImageBeUpdated(logger *logrus.Entry, autoUpdateMachineImageVersion bool, machineImage *gardencorev1beta1.MachineImage, shootMachineImage *gardencorev1beta1.ShootMachineImage) (shouldBeUpdated bool, reason *string, updatedMachineImage *gardencorev1beta1.ShootMachineImage, error error) {
versionExistsInCloudProfile, versionIndex := gardencorev1beta1helper.ShootMachineImageVersionExists(*machineImage, *shootMachineImage)
var reasonForUpdate string
forceUpdateRequired := ForceMachineImageUpdateRequired(shootMachineImage, *machineImage)
if !versionExistsInCloudProfile || autoUpdateMachineImageVersion || forceUpdateRequired {
// safe operation, as Shoot machine image version can only be a valid semantic version
shootSemanticVersion := *semver.MustParse(*shootMachineImage.Version)
// get latest version qualifying for Shoot machine image update
qualifyingVersionFound, latestShootMachineImage, err := gardencorev1beta1helper.GetLatestQualifyingShootMachineImage(*machineImage, gardencorev1beta1helper.FilterLowerVersion(shootSemanticVersion))
if err != nil {
return false, nil, nil, fmt.Errorf("an error occured while determining the latest Shoot Machine Image for machine image %q: %s", machineImage.Name, err.Error())
}
// this is a special case when a Shoot is using a preview version. Preview versions should not be updated-to and are therefore not part of the qualifying versions.
// if no qualifying version can be found and the Shoot is already using a preview version, then do nothing.
if !qualifyingVersionFound && versionExistsInCloudProfile && machineImage.Versions[versionIndex].Classification != nil && *machineImage.Versions[versionIndex].Classification == gardencorev1beta1.ClassificationPreview {
logger.Debugf("MachineImage update not required. Already using preview version.")
return false, nil, nil, nil
}
// otherwise, there should always be a qualifying version (at least the Shoot's machine image version itself).
if !qualifyingVersionFound {
return false, nil, nil, fmt.Errorf("no latest qualifying Shoot machine image could be determined for machine image %q. Either the machine image is reaching end of life and migration to another machine image is required or there is a misconfiguration in the CloudProfile. If it is the latter, make sure the machine image in the CloudProfile has at least one version that is not expired, not in preview and greater or equal to the current Shoot image version %q", machineImage.Name, *shootMachineImage.Version)
}
if *latestShootMachineImage.Version == *shootMachineImage.Version {
logger.Debugf("MachineImage update not required. Already up to date.")
return false, nil, nil, nil
}
if !versionExistsInCloudProfile {
// deletion a machine image that is still in use by a Shoot is blocked in the apiserver. However it is still required,
// because old installations might still have shoot's that have no corresponding version in the CloudProfile.
reasonForUpdate = "Version does not exist in CloudProfile"
} else if autoUpdateMachineImageVersion {
reasonForUpdate = "AutoUpdate of MachineImage configured"
} else if forceUpdateRequired {
reasonForUpdate = "MachineImage expired - force update required"
}
return true, &reasonForUpdate, latestShootMachineImage, nil
}
return false, nil, nil, nil
}
// ForceMachineImageUpdateRequired checks if the shoots current machine image has to be forcefully updated
func ForceMachineImageUpdateRequired(shootCurrentImage *gardencorev1beta1.ShootMachineImage, imageCloudProvider gardencorev1beta1.MachineImage) bool {
for _, image := range imageCloudProvider.Versions {
if shootCurrentImage.Version != nil && *shootCurrentImage.Version != image.Version {
continue
}
return ExpirationDateExpired(image.ExpirationDate)
}
return false
}
// ExpirationDateExpired returns if now is equal or after the given expirationDate
func ExpirationDateExpired(timestamp *metav1.Time) bool {
if timestamp == nil {
return false
}
return time.Now().UTC().After(timestamp.Time) || time.Now().UTC().Equal(timestamp.Time)
}