/
admission.go
336 lines (278 loc) · 12.5 KB
/
admission.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
// Copyright (c) 2020 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package extensionvalidation
import (
"context"
"errors"
"fmt"
"io"
"github.com/gardener/gardener/pkg/apis/core"
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
extensionsv1alpha1 "github.com/gardener/gardener/pkg/apis/extensions/v1alpha1"
admissioninitializer "github.com/gardener/gardener/pkg/apiserver/admission/initializer"
externalcoreinformers "github.com/gardener/gardener/pkg/client/core/informers/externalversions"
corev1beta1listers "github.com/gardener/gardener/pkg/client/core/listers/core/v1beta1"
"github.com/gardener/gardener/pkg/features"
dnsv1alpha1 "github.com/gardener/external-dns-management/pkg/apis/dns/v1alpha1"
"github.com/hashicorp/go-multierror"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/apiserver/pkg/admission"
utilfeature "k8s.io/apiserver/pkg/util/feature"
)
const (
// PluginName is the name of this admission plugin.
PluginName = "ExtensionValidator"
)
// Register registers a plugin.
func Register(plugins *admission.Plugins) {
plugins.Register(PluginName, NewFactory)
}
// NewFactory creates a new PluginFactory.
func NewFactory(config io.Reader) (admission.Interface, error) {
return New()
}
// ExtensionValidator contains listers and admission handler.
type ExtensionValidator struct {
*admission.Handler
controllerRegistrationLister corev1beta1listers.ControllerRegistrationLister
backupBucketLister corev1beta1listers.BackupBucketLister
readyFunc admission.ReadyFunc
}
var (
_ = admissioninitializer.WantsExternalCoreInformerFactory(&ExtensionValidator{})
readyFuncs []admission.ReadyFunc
)
// New creates a new ExtensionValidator admission plugin.
func New() (*ExtensionValidator, error) {
return &ExtensionValidator{
Handler: admission.NewHandler(admission.Create, admission.Update),
}, nil
}
// AssignReadyFunc assigns the ready function to the admission handler.
func (e *ExtensionValidator) AssignReadyFunc(f admission.ReadyFunc) {
e.readyFunc = f
e.SetReadyFunc(f)
}
// SetExternalCoreInformerFactory sets the external garden core informer factory.
func (e *ExtensionValidator) SetExternalCoreInformerFactory(f externalcoreinformers.SharedInformerFactory) {
controllerRegistrationInformer := f.Core().V1beta1().ControllerRegistrations()
e.controllerRegistrationLister = controllerRegistrationInformer.Lister()
backupBucketInformer := f.Core().V1beta1().BackupBuckets()
e.backupBucketLister = backupBucketInformer.Lister()
readyFuncs = append(readyFuncs, controllerRegistrationInformer.Informer().HasSynced, backupBucketInformer.Informer().HasSynced)
}
func (e *ExtensionValidator) waitUntilReady(attrs admission.Attributes) error {
// Wait until the caches have been synced
if e.readyFunc == nil {
e.AssignReadyFunc(func() bool {
for _, readyFunc := range readyFuncs {
if !readyFunc() {
return false
}
}
return true
})
}
if !e.WaitForReady() {
return admission.NewForbidden(attrs, errors.New("not yet ready to handle request"))
}
return nil
}
// ValidateInitialization checks whether the plugin was correctly initialized.
func (e *ExtensionValidator) ValidateInitialization() error {
if e.controllerRegistrationLister == nil {
return errors.New("missing ControllerRegistration lister")
}
if e.backupBucketLister == nil {
return errors.New("missing BackupBucket lister")
}
return nil
}
var _ admission.ValidationInterface = &ExtensionValidator{}
// Validate makes admissions decisions based on the extension types.
func (e *ExtensionValidator) Validate(ctx context.Context, a admission.Attributes, o admission.ObjectInterfaces) error {
if err := e.waitUntilReady(a); err != nil {
return fmt.Errorf("err while waiting for ready %w", err)
}
switch a.GetKind().GroupKind() {
case core.Kind("BackupBucket"), core.Kind("BackupEntry"), core.Kind("Seed"), core.Kind("Shoot"):
default:
return nil
}
controllerRegistrationList, err := e.controllerRegistrationLister.List(labels.Everything())
if err != nil {
return err
}
var (
kindToTypesMap = computeRegisteredPrimaryExtensionKindTypes(controllerRegistrationList)
validationError error
)
switch a.GetKind().GroupKind() {
case core.Kind("BackupBucket"):
backupBucket, ok := a.GetObject().(*core.BackupBucket)
if !ok {
return apierrors.NewBadRequest("could not convert resource into BackupBucket object")
}
validationError = e.validateBackupBucket(kindToTypesMap, backupBucket.Spec)
case core.Kind("BackupEntry"):
backupEntry, ok := a.GetObject().(*core.BackupEntry)
if !ok {
return apierrors.NewBadRequest("could not convert resource into BackupEntry object")
}
backupBucket, err := e.backupBucketLister.Get(backupEntry.Spec.BucketName)
if err != nil {
return err
}
validationError = e.validateBackupEntry(kindToTypesMap, backupBucket.Spec.Provider.Type)
case core.Kind("Seed"):
seed, ok := a.GetObject().(*core.Seed)
if !ok {
return apierrors.NewBadRequest("could not convert resource into Seed object")
}
validationError = e.validateSeed(kindToTypesMap, seed.Spec)
case core.Kind("Shoot"):
shoot, ok := a.GetObject().(*core.Shoot)
if !ok {
return apierrors.NewBadRequest("could not convert resource into Shoot object")
}
validationError = e.validateShoot(kindToTypesMap, shoot.Spec)
}
if validationError != nil {
return admission.NewForbidden(a, validationError)
}
return nil
}
func (e *ExtensionValidator) validateBackupBucket(kindToTypesMap map[string]sets.String, spec core.BackupBucketSpec) error {
return isExtensionRegistered(
kindToTypesMap,
extensionsv1alpha1.BackupBucketResource,
spec.Provider.Type,
"given BackupBucket uses non-registered provider type: "+field.NewPath("spec", "provider", "type").String(),
)
}
func (e *ExtensionValidator) validateBackupEntry(kindToTypesMap map[string]sets.String, bucketType string) error {
return isExtensionRegistered(
kindToTypesMap,
extensionsv1alpha1.BackupEntryResource,
bucketType,
fmt.Sprintf("given BackupEntry references bucket (%s) using non-registered provider type", field.NewPath("spec", "bucketName")),
)
}
func (e *ExtensionValidator) validateSeed(kindToTypesMap map[string]sets.String, spec core.SeedSpec) error {
var (
message = "given Seed uses non-registered"
requiredExtensions = requiredExtensions{
{extensionsv1alpha1.ControlPlaneResource, spec.Provider.Type, fmt.Sprintf("%s provider type: %s", message, field.NewPath("spec", "provider", "type"))},
}
)
if spec.Backup != nil {
msg := fmt.Sprintf("%s backup provider type: %s", message, field.NewPath("spec", "backup", "provider"))
requiredExtensions = append(
requiredExtensions,
requiredExtension{extensionsv1alpha1.BackupBucketResource, spec.Backup.Provider, msg},
requiredExtension{extensionsv1alpha1.BackupEntryResource, spec.Backup.Provider, msg},
)
}
if spec.Ingress != nil && spec.DNS.Provider != nil {
provider := spec.DNS.Provider
if utilfeature.DefaultFeatureGate.Enabled(features.UseDNSRecords) {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.DNSRecordResource, provider.Type, fmt.Sprintf("%s extension type: %s", message, field.NewPath("spec", "dns", "provider").Child("type"))})
} else {
requiredExtensions = append(requiredExtensions, requiredExtension{dnsv1alpha1.DNSProviderKind, provider.Type, fmt.Sprintf("%s dns type: %s", message, field.NewPath("spec", "dns", "provider").Child("type"))})
}
}
return requiredExtensions.areRegistered(kindToTypesMap)
}
func (e *ExtensionValidator) validateShoot(kindToTypesMap map[string]sets.String, spec core.ShootSpec) error {
var (
message = "given Shoot uses non-registered"
providerTypeMsg = fmt.Sprintf("%s provider type: %s", message, field.NewPath("spec", "provider", "type"))
requiredExtensions = requiredExtensions{
{extensionsv1alpha1.ControlPlaneResource, spec.Provider.Type, providerTypeMsg},
{extensionsv1alpha1.InfrastructureResource, spec.Provider.Type, providerTypeMsg},
{extensionsv1alpha1.WorkerResource, spec.Provider.Type, providerTypeMsg},
{extensionsv1alpha1.NetworkResource, spec.Networking.Type, fmt.Sprintf("%s networking type: %s", message, field.NewPath("spec", "networking", "type"))},
}
)
if spec.DNS != nil {
for i, provider := range spec.DNS.Providers {
if provider.Type == nil {
continue
}
requiredExtensions = append(requiredExtensions, requiredExtension{dnsv1alpha1.DNSProviderKind, *provider.Type, fmt.Sprintf("%s dns type: %s", message, field.NewPath("spec", "dns", "providers").Index(i).Child("type"))})
if provider.Primary != nil && *provider.Primary && utilfeature.DefaultFeatureGate.Enabled(features.UseDNSRecords) {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.DNSRecordResource, *provider.Type, fmt.Sprintf("%s extension type: %s", message, field.NewPath("spec", "dns", "providers").Index(i).Child("type"))})
}
}
}
for i, extension := range spec.Extensions {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.ExtensionResource, extension.Type, fmt.Sprintf("%s extension type: %s", message, field.NewPath("spec", "extensions").Index(i).Child("type"))})
}
for i, worker := range spec.Provider.Workers {
if worker.CRI != nil {
for j, cr := range worker.CRI.ContainerRuntimes {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.ContainerRuntimeResource, cr.Type, fmt.Sprintf("%s container runtime type: %s", message, field.NewPath("spec", "provider", "workers").Index(i).Child("cri", "containerRuntimes").Index(j).Child("type"))})
}
}
if worker.Machine.Image == nil {
continue
}
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.OperatingSystemConfigResource, worker.Machine.Image.Name, fmt.Sprintf("%s operating system type: %s", message, field.NewPath("spec", "provider", "workers").Index(i).Child("machine", "image", "name"))})
}
return requiredExtensions.areRegistered(kindToTypesMap)
}
// Helper functions
type requiredExtension struct {
extensionKind string
extensionType string
message string
}
type requiredExtensions []requiredExtension
func (r requiredExtensions) areRegistered(kindToTypesMap map[string]sets.String) error {
var result error
for _, requiredExtension := range r {
if err := isExtensionRegistered(kindToTypesMap, requiredExtension.extensionKind, requiredExtension.extensionType, requiredExtension.message); err != nil {
result = multierror.Append(result, err)
}
}
return result
}
// isExtensionRegistered takes a map of registered kinds to a set of types and a kind/type to verify. If the provided
// kind/type combination is registered then it returns nil, otherwise it returns an error with the given message.
func isExtensionRegistered(kindToTypesMap map[string]sets.String, extensionKind, extensionType, message string) error {
if types, ok := kindToTypesMap[extensionKind]; !ok || !types.Has(extensionType) {
return fmt.Errorf("%s (%q)", message, extensionType)
}
return nil
}
// computeRegisteredPrimaryExtensionKindTypes computes a map that maps the extension kind to the set of types that are
// registered (only if primary=true), e.g. {ControlPlane=>{foo,bar,baz}, Network=>{a,b,c}}.
func computeRegisteredPrimaryExtensionKindTypes(controllerRegistrationList []*gardencorev1beta1.ControllerRegistration) map[string]sets.String {
out := map[string]sets.String{}
for _, controllerRegistration := range controllerRegistrationList {
for _, resource := range controllerRegistration.Spec.Resources {
if resource.Primary != nil && !*resource.Primary {
continue
}
if _, ok := out[resource.Kind]; !ok {
out[resource.Kind] = sets.NewString()
}
out[resource.Kind].Insert(resource.Type)
}
}
return out
}