-
Notifications
You must be signed in to change notification settings - Fork 456
/
admission.go
418 lines (344 loc) · 14.9 KB
/
admission.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
// Copyright 2020 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package extensionvalidation
import (
"context"
"errors"
"fmt"
"io"
"github.com/hashicorp/go-multierror"
apiequality "k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/apiserver/pkg/admission"
"k8s.io/utils/pointer"
"github.com/gardener/gardener/pkg/apis/core"
gardencorehelper "github.com/gardener/gardener/pkg/apis/core/helper"
extensionsv1alpha1 "github.com/gardener/gardener/pkg/apis/extensions/v1alpha1"
admissioninitializer "github.com/gardener/gardener/pkg/apiserver/admission/initializer"
gardencoreinformers "github.com/gardener/gardener/pkg/client/core/informers/internalversion"
gardencorelisters "github.com/gardener/gardener/pkg/client/core/listers/core/internalversion"
plugin "github.com/gardener/gardener/plugin/pkg"
)
// Register registers a plugin.
func Register(plugins *admission.Plugins) {
plugins.Register(plugin.PluginNameExtensionValidator, NewFactory)
}
// NewFactory creates a new PluginFactory.
func NewFactory(_ io.Reader) (admission.Interface, error) {
return New()
}
// ExtensionValidator contains listers and admission handler.
type ExtensionValidator struct {
*admission.Handler
controllerRegistrationLister gardencorelisters.ControllerRegistrationLister
backupBucketLister gardencorelisters.BackupBucketLister
readyFunc admission.ReadyFunc
}
var (
_ = admissioninitializer.WantsInternalCoreInformerFactory(&ExtensionValidator{})
readyFuncs []admission.ReadyFunc
)
// New creates a new ExtensionValidator admission plugin.
func New() (*ExtensionValidator, error) {
return &ExtensionValidator{
Handler: admission.NewHandler(admission.Create, admission.Update),
}, nil
}
// AssignReadyFunc assigns the ready function to the admission handler.
func (e *ExtensionValidator) AssignReadyFunc(f admission.ReadyFunc) {
e.readyFunc = f
e.SetReadyFunc(f)
}
// SetInternalCoreInformerFactory gets Lister from SharedInformerFactory.
func (e *ExtensionValidator) SetInternalCoreInformerFactory(f gardencoreinformers.SharedInformerFactory) {
controllerRegistrationInformer := f.Core().InternalVersion().ControllerRegistrations()
e.controllerRegistrationLister = controllerRegistrationInformer.Lister()
backupBucketInformer := f.Core().InternalVersion().BackupBuckets()
e.backupBucketLister = backupBucketInformer.Lister()
readyFuncs = append(readyFuncs, controllerRegistrationInformer.Informer().HasSynced, backupBucketInformer.Informer().HasSynced)
}
func (e *ExtensionValidator) waitUntilReady(attrs admission.Attributes) error {
// Wait until the caches have been synced
if e.readyFunc == nil {
e.AssignReadyFunc(func() bool {
for _, readyFunc := range readyFuncs {
if !readyFunc() {
return false
}
}
return true
})
}
if !e.WaitForReady() {
return admission.NewForbidden(attrs, errors.New("not yet ready to handle request"))
}
return nil
}
// ValidateInitialization checks whether the plugin was correctly initialized.
func (e *ExtensionValidator) ValidateInitialization() error {
if e.controllerRegistrationLister == nil {
return errors.New("missing ControllerRegistration lister")
}
if e.backupBucketLister == nil {
return errors.New("missing BackupBucket lister")
}
return nil
}
var _ admission.ValidationInterface = &ExtensionValidator{}
// Validate makes admissions decisions based on the extension types.
func (e *ExtensionValidator) Validate(_ context.Context, a admission.Attributes, _ admission.ObjectInterfaces) error {
if err := e.waitUntilReady(a); err != nil {
return fmt.Errorf("err while waiting for ready %w", err)
}
switch a.GetKind().GroupKind() {
case core.Kind("BackupBucket"), core.Kind("BackupEntry"), core.Kind("Seed"), core.Kind("Shoot"):
default:
return nil
}
controllerRegistrationList, err := e.controllerRegistrationLister.List(labels.Everything())
if err != nil {
return err
}
var (
kindToTypesMap = computeRegisteredPrimaryExtensionKindTypes(controllerRegistrationList)
validationError error
)
switch a.GetKind().GroupKind() {
case core.Kind("BackupBucket"):
backupBucket, ok := a.GetObject().(*core.BackupBucket)
if !ok {
return apierrors.NewBadRequest("could not convert object into BackupBucket object")
}
oldBackupBucket := &core.BackupBucket{}
if oldObj := a.GetOldObject(); oldObj != nil {
oldBackupBucket, ok = oldObj.(*core.BackupBucket)
if !ok {
return apierrors.NewBadRequest("could not convert old object into BackupBucket object")
}
}
if !apiequality.Semantic.DeepEqual(backupBucket.Spec, oldBackupBucket.Spec) {
validationError = e.validateBackupBucket(kindToTypesMap, backupBucket.Spec)
}
case core.Kind("BackupEntry"):
backupEntry, ok := a.GetObject().(*core.BackupEntry)
if !ok {
return apierrors.NewBadRequest("could not convert object into BackupEntry object")
}
oldBackupEntry := &core.BackupEntry{}
if oldObj := a.GetOldObject(); oldObj != nil {
oldBackupEntry, ok = oldObj.(*core.BackupEntry)
if !ok {
return apierrors.NewBadRequest("could not convert old object into BackupEntry object")
}
}
if !apiequality.Semantic.DeepEqual(backupEntry.Spec, oldBackupEntry.Spec) {
backupBucket, err := e.backupBucketLister.Get(backupEntry.Spec.BucketName)
if err != nil {
return err
}
validationError = e.validateBackupEntry(kindToTypesMap, backupBucket.Spec.Provider.Type)
}
case core.Kind("Seed"):
seed, ok := a.GetObject().(*core.Seed)
if !ok {
return apierrors.NewBadRequest("could not convert object into Seed object")
}
oldSeed := &core.Seed{}
if oldObj := a.GetOldObject(); oldObj != nil {
oldSeed, ok = oldObj.(*core.Seed)
if !ok {
return apierrors.NewBadRequest("could not convert old object into Seed object")
}
}
if !apiequality.Semantic.DeepEqual(seed.Spec, oldSeed.Spec) {
validationError = e.validateSeed(kindToTypesMap, seed.Spec)
}
case core.Kind("Shoot"):
shoot, ok := a.GetObject().(*core.Shoot)
if !ok {
return apierrors.NewBadRequest("could not convert object into Shoot object")
}
oldShoot := &core.Shoot{}
if oldObj := a.GetOldObject(); oldObj != nil {
oldShoot, ok = oldObj.(*core.Shoot)
if !ok {
return apierrors.NewBadRequest("could not convert old object into Shoot object")
}
}
if !apiequality.Semantic.DeepEqual(shoot.Spec, oldShoot.Spec) {
validationError = e.validateShoot(kindToTypesMap, computeWorkerlessSupportedExtensionTypes(controllerRegistrationList), shoot.Spec, gardencorehelper.IsWorkerless(shoot))
}
}
if validationError != nil {
return admission.NewForbidden(a, validationError)
}
return nil
}
func (e *ExtensionValidator) validateBackupBucket(kindToTypesMap map[string]sets.Set[string], spec core.BackupBucketSpec) error {
return isExtensionRegistered(
kindToTypesMap,
extensionsv1alpha1.BackupBucketResource,
spec.Provider.Type,
"given BackupBucket uses non-registered provider type: "+field.NewPath("spec", "provider", "type").String(),
)
}
func (e *ExtensionValidator) validateBackupEntry(kindToTypesMap map[string]sets.Set[string], bucketType string) error {
return isExtensionRegistered(
kindToTypesMap,
extensionsv1alpha1.BackupEntryResource,
bucketType,
fmt.Sprintf("given BackupEntry references bucket (%s) using non-registered provider type", field.NewPath("spec", "bucketName")),
)
}
func (e *ExtensionValidator) validateSeed(kindToTypesMap map[string]sets.Set[string], spec core.SeedSpec) error {
var (
message = "given Seed uses non-registered"
requiredExtensions = requiredExtensions{
{extensionsv1alpha1.ControlPlaneResource, spec.Provider.Type, fmt.Sprintf("%s provider type: %s", message, field.NewPath("spec", "provider", "type"))},
}
)
if spec.Backup != nil {
msg := fmt.Sprintf("%s backup provider type: %s", message, field.NewPath("spec", "backup", "provider"))
requiredExtensions = append(
requiredExtensions,
requiredExtension{extensionsv1alpha1.BackupBucketResource, spec.Backup.Provider, msg},
requiredExtension{extensionsv1alpha1.BackupEntryResource, spec.Backup.Provider, msg},
)
}
if spec.Ingress != nil && spec.DNS.Provider != nil {
provider := spec.DNS.Provider
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.DNSRecordResource, provider.Type, fmt.Sprintf("%s extension type: %s", message, field.NewPath("spec", "dns", "provider").Child("type"))})
}
return requiredExtensions.areRegistered(kindToTypesMap)
}
func (e *ExtensionValidator) validateShoot(kindToTypesMap map[string]sets.Set[string], workerlessSupportedExtensionTypes sets.Set[string], spec core.ShootSpec, workerless bool) error {
var (
message = "given Shoot uses non-registered"
providerTypeMsg = fmt.Sprintf("%s provider type: %s", message, field.NewPath("spec", "provider", "type"))
requiredExtensions = requiredExtensions{}
result error
)
if !workerless {
requiredExtensions = append(requiredExtensions,
requiredExtension{extensionsv1alpha1.ControlPlaneResource, spec.Provider.Type, providerTypeMsg},
requiredExtension{extensionsv1alpha1.InfrastructureResource, spec.Provider.Type, providerTypeMsg},
requiredExtension{extensionsv1alpha1.WorkerResource, spec.Provider.Type, providerTypeMsg},
)
if spec.Networking != nil && spec.Networking.Type != nil {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.NetworkResource, *spec.Networking.Type, fmt.Sprintf("%s networking type: %s", message, field.NewPath("spec", "networking", "type"))})
}
}
if spec.DNS != nil {
for i, provider := range spec.DNS.Providers {
if provider.Type == nil || *provider.Type == core.DNSUnmanaged {
continue
}
if provider.Primary != nil && *provider.Primary {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.DNSRecordResource, *provider.Type, fmt.Sprintf("%s extension type: %s", message, field.NewPath("spec", "dns", "providers").Index(i).Child("type"))})
}
}
}
for i, extension := range spec.Extensions {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.ExtensionResource, extension.Type, fmt.Sprintf("extension type: %s", field.NewPath("spec", "extensions").Index(i).Child("type"))})
}
for i, worker := range spec.Provider.Workers {
if worker.CRI != nil {
for j, cr := range worker.CRI.ContainerRuntimes {
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.ContainerRuntimeResource, cr.Type, fmt.Sprintf("%s container runtime type: %s", message, field.NewPath("spec", "provider", "workers").Index(i).Child("cri", "containerRuntimes").Index(j).Child("type"))})
}
}
if worker.Machine.Image == nil {
continue
}
requiredExtensions = append(requiredExtensions, requiredExtension{extensionsv1alpha1.OperatingSystemConfigResource, worker.Machine.Image.Name, fmt.Sprintf("%s operating system type: %s", message, field.NewPath("spec", "provider", "workers").Index(i).Child("machine", "image", "name"))})
}
if err := requiredExtensions.areRegistered(kindToTypesMap); err != nil {
result = multierror.Append(result, err)
}
if workerless {
if err := requiredExtensions.areSupportedForWorkerlessShoots(workerlessSupportedExtensionTypes); err != nil {
result = multierror.Append(result, err)
}
}
return result
}
// Helper functions
type requiredExtension struct {
extensionKind string
extensionType string
message string
}
type requiredExtensions []requiredExtension
func (r requiredExtensions) areRegistered(kindToTypesMap map[string]sets.Set[string]) error {
var result error
for _, requiredExtension := range r {
if err := isExtensionRegistered(kindToTypesMap, requiredExtension.extensionKind, requiredExtension.extensionType, requiredExtension.message); err != nil {
result = multierror.Append(result, err)
}
}
return result
}
// isExtensionRegistered takes a map of registered kinds to a set of types and a kind/type to verify. If the provided
// kind/type combination is registered then it returns nil, otherwise it returns an error with the given message.
func isExtensionRegistered(kindToTypesMap map[string]sets.Set[string], extensionKind, extensionType, message string) error {
if types, ok := kindToTypesMap[extensionKind]; !ok || !types.Has(extensionType) {
return fmt.Errorf("given Shoot uses non-registered %s (%q)", message, extensionType)
}
return nil
}
// computeRegisteredPrimaryExtensionKindTypes computes a map that maps the extension kind to the set of types that are
// registered (only if primary=true), e.g. {ControlPlane=>{foo,bar,baz}, Network=>{a,b,c}}.
func computeRegisteredPrimaryExtensionKindTypes(controllerRegistrationList []*core.ControllerRegistration) map[string]sets.Set[string] {
out := map[string]sets.Set[string]{}
for _, controllerRegistration := range controllerRegistrationList {
for _, resource := range controllerRegistration.Spec.Resources {
if resource.Primary != nil && !*resource.Primary {
continue
}
if _, ok := out[resource.Kind]; !ok {
out[resource.Kind] = sets.New[string]()
}
out[resource.Kind].Insert(resource.Type)
}
}
return out
}
// computeWorkerlessSupportedExtensionTypes computes Extension types that are supported for workerless Shoots.
func computeWorkerlessSupportedExtensionTypes(controllerRegistrationList []*core.ControllerRegistration) sets.Set[string] {
out := sets.Set[string]{}
for _, controllerRegistration := range controllerRegistrationList {
for _, resource := range controllerRegistration.Spec.Resources {
if resource.Kind != extensionsv1alpha1.ExtensionResource || !pointer.BoolDeref(resource.WorkerlessSupported, false) {
continue
}
out.Insert(resource.Type)
}
}
return out
}
func (r requiredExtensions) areSupportedForWorkerlessShoots(workerlessSupportedExtensionTypes sets.Set[string]) error {
var result error
for _, requiredExtension := range r {
if requiredExtension.extensionKind != extensionsv1alpha1.ExtensionResource {
continue
}
if !workerlessSupportedExtensionTypes.Has(requiredExtension.extensionType) {
result = multierror.Append(result, fmt.Errorf("given Shoot is workerless and uses non-supported %s (%q)", requiredExtension.message, requiredExtension.extensionType))
}
}
return result
}