Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed Admission Webhook preventing accidental deletion of extension CR(D)s #2053

Closed
rfranzke opened this issue Mar 16, 2020 · 0 comments · Fixed by #2066
Closed

Seed Admission Webhook preventing accidental deletion of extension CR(D)s #2053

rfranzke opened this issue Mar 16, 2020 · 0 comments · Fixed by #2066
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@rfranzke
Copy link
Member

What would you like to be added:
Let's add a new separate binary to g/g that serves a validation webhook in the seed clusters in order to prevent accidental deletion of extension CR(D)s. It shall only allow the deletion if it was confirmed before (similar to how shoot/project validation is prevented).

Why is this needed:
Deleting an extension CRD can have catastrophic and hard-to-recover consequences, hence, let's protect them from accidental deletion.

@rfranzke rfranzke added kind/enhancement Enhancement, improvement, extension status/in-progress labels Mar 16, 2020
@rfranzke rfranzke self-assigned this Mar 16, 2020
@ghost ghost removed the status/in-progress label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant