Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect etcd resources #4833

Closed
timuthy opened this issue Oct 13, 2021 · 2 comments · Fixed by #4861
Closed

Protect etcd resources #4833

timuthy opened this issue Oct 13, 2021 · 2 comments · Fixed by #4861
Assignees
@vanjiii
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@timuthy
Copy link
Contributor

timuthy commented Oct 13, 2021 •
edited

How to categorize this issue?

/area control-plane
/kind enhancement
/priority 3

What would you like to be added:
Prevent accidental deletions of etcd resource in seed clusters.

Why is this needed:
#2066 added a deletion protection for Gardener extension resources. I don't see a reason why we shouldn't do the same for etcd. Deleting this resource by accident is at least as critical as it is for other extensions like Infrastructure or ControlPlane.
@timuthy timuthy added the kind/enhancement Enhancement, improvement, extension label Oct 13, 2021
@gardener-robot gardener-robot added area/control-plane Control plane related priority/3 Priority (lower number equals higher priority) labels Oct 13, 2021
@timuthy
Copy link
Contributor Author

timuthy commented Oct 13, 2021

/cc @vanjiii

@vanjiii
Copy link
Contributor

vanjiii commented Oct 14, 2021

/assign

@vanjiii vanjiii mentioned this issue Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanjiii vanjiii

Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect etcd resource from deletion vanjiii/gardener
3 participants
@vanjiii @timuthy @gardener-robot