Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the go.mod version to go1.17 #4843

Closed
ialidzhikov opened this issue Oct 14, 2021 · 1 comment · Fixed by #5599
Closed

Update the go.mod version to go1.17 #4843

ialidzhikov opened this issue Oct 14, 2021 · 1 comment · Fixed by #5599
Assignees
@ialidzhikov
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/4 Priority (lower number equals higher priority)

Comments

@ialidzhikov
Copy link
Member

How to categorize this issue?

/area open-source
/kind enhancement
/priority 4

What would you like to be added:

From #4822 (comment):

I didn't update the go version of the module (the one in go.mod) because to be honest I am not able to completely follow the changes to the module graph pruning. go1.17 should be able to work with go1.16 module. This is actually also how kubernetes/kubernetes upgraded to go1.17 - the go runtime version is go1.17 but the module version is still go1.16 - ref kubernetes/kubernetes#103692. So it should not be a problem if we delay to module version update to another PR.

Why is this needed:
To keep the module version up-to-date
@ialidzhikov ialidzhikov added the kind/enhancement Enhancement, improvement, extension label Oct 14, 2021
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related priority/4 Priority (lower number equals higher priority) labels Oct 14, 2021
@ialidzhikov ialidzhikov mentioned this issue Oct 14, 2021
Merged
2 tasks
@ialidzhikov
Copy link
Member Author

/assign

@ialidzhikov ialidzhikov mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ialidzhikov ialidzhikov

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/4 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the go.mod version to go1.17 ialidzhikov/gardener
2 participants
@ialidzhikov @gardener-robot