Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternate credentials secret field #3

Open
deitch opened this issue Apr 1, 2021 · 0 comments
Open

Add support for alternate credentials secret field #3

deitch opened this issue Apr 1, 2021 · 0 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@deitch
Copy link
Collaborator

deitch commented Apr 1, 2021

As discussed with @prashanth26 and @AxiomSamarth in this comment, we should support having the alternate credentials field.

The PR that added support to MCM and back-filled it into existing in-tree providers is here.

Sample validation would be:

		if "" == string(secret.Data[api.APIKey]) && "" == string(secret.Data[api.AlternateAPIKey]) {
			allErrs = append(allErrs, field.Required(fldPath.Child(api.APIKey), fmt.Sprintf("Required Equinix Metal API Key one of '%s' or '%s'", api.APIKey, api.AlternateAPIKey)))
		}
@deitch deitch added the kind/enhancement Enhancement, improvement, extension label Apr 1, 2021
@deitch deitch mentioned this issue Apr 1, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 29, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants