Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose allow-listed Prometheus metrics to end-users #3

Open
vlerenc opened this issue Sep 22, 2020 · 1 comment
Open

Expose allow-listed Prometheus metrics to end-users #3

vlerenc opened this issue Sep 22, 2020 · 1 comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@vlerenc
Copy link
Member

vlerenc commented Sep 22, 2020

End users would benefit from direct access to Prometheus, but we were always reluctant to just open up Prometheus as it also holds "implementation-detail" metrics that end users shouldn't be concerned with (e.g. in relation to internal control plane components that no end user directly interacts with).

According to @wyb1, we have the following options:

  1. Expose just allow-listed metrics via proxy: This would have the disadvantages of manually maintaining the allow list and that it wouldn't include Prometheus itself, just the metrics via a proxy.
  2. Set up another (end-user) Prometheus scrapping our (main) Prometheus: This would have the disadvantages of manually maintaining the allow list and setting up (TCD) and operating (TCO) another Prometheus instance.
  3. Just open up our (main) Prometheus behind a feature gate: This would have the disadvantage, once the feature gate is opened, that all metrics would be exposed.
@vlerenc vlerenc added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension labels Sep 28, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 28, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 22, 2021
@wyb1
Copy link

wyb1 commented Nov 22, 2021

Discussion to open up prometheus entirely: gardener/gardener#4800

@wyb1 wyb1 added lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Jun 3, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Dec 22, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants