Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for callbacks to properly fade and loop sound effects in Sherlock and The Lurking Horror. Basically I've copied and pasted code from Frotz, so it might not be super clean and consistent, but it seems to work.
Main caveats: only tested on macOS. Seems to play samples faster (at double speed?) than the almost identical code in Spatterlight and Frotz. Is this due to a difference between SDL 1 and SDL 2?
The latest Bocfel seems to require an extra ZTERP_GLK_BLORB flag to build with Blorb support.
EDIT: A simple way to test this is to type >BLOW WHISTLE, WAIT at the beginning of Sherlock: The Riddle of the Crown Jewels. Requires the right version of the game and the .blb version of the sounds, of course.