Support images in SCARE #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by writing a temporary PIC0 file, displaying it, then removing it. A future Gargoyle extension might allow memory-based image display, rendering this unnecessary, but it works well enough for the time being. The PIC0 file must be in the game directory, though, so if that's not writable, this won't work. Many games display an image on startup then clear the screen, which obliterates the image. The official Adrift runner, by default, has a separate window-manager window showing the image, so it doesn't matter if the screen is cleared. However, you can configure it to display inline images, in which case, just like in SCARE, they disappear, although unlike Gargoyle, you can scroll back past cleared screens in the Adrift runner. The Adrift runner also supports a Glk-like window on the top or right holding the graphic (plus a map), so theoretically SCARE could be modified to support both inline and windowed images as well, but for the time being, just do inline. This loses title screen images, but Gargoyle never had that before, so it's not a change, and games with actual inline images (such as "The PK Girl") now work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by writing a temporary PIC0 file, displaying it, then removing it. A future Gargoyle extension might allow memory-based image display, rendering this unnecessary, but it works well enough for the time being. The PIC0 file must be in the game directory, though, so if that's not writable, this won't work.
Many games display an image on startup then clear the screen, which obliterates the image. The official Adrift runner, by default, has a separate window-manager window showing the image, so it doesn't matter if the screen is cleared. However, you can configure it to display inline images, in which case, just like in SCARE, they disappear, although unlike Gargoyle, you can scroll back past cleared screens in the Adrift runner.
The Adrift runner also supports a Glk-like window on the top or right holding the graphic (plus a map), so theoretically SCARE could be modified to support both inline and windowed images as well, but for the time being, just do inline. This loses title screen images, but Gargoyle never had that before, so it's not a change, and games with actual inline images (such as "The PK Girl") now work.