Feature/dataset jsonld comp #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmeeh
requested changes
Feb 11, 2020
| "@type": "Dataset", | ||
| "description": "${description}", | ||
| "name": "${name}"${ | ||
| license |
There was a problem hiding this comment.
At the moment if license is added it will be invalid JSON due to no trailing comma on name.
To fix this if you put name last and then update license to always have trailing comma like so: "license": "${license}",
There was a problem hiding this comment.
Hi!
I will actually be a comma on name if license is provided.
See line 23.
The result will be like this:
{
"@context": "http://schema.org",
"@type": "Dataset",
"description": "The description needs to be at least 50 characters long",
"name": "name of the dataset",
"license": "https//www.example.com"
}
The solution is the same as providerUrl in course component.
garmeeh
approved these changes
Feb 21, 2020
| "@type": "Dataset", | ||
| "description": "${description}", | ||
| "name": "${name}"${ | ||
| license |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jsonld for dataset.