Disable use @babel/runtime-corejs2
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmeeh
reviewed
Feb 21, 2020
| @@ -1,5 +1,9 @@ | |||
| { | |||
| presets: ['next/babel', '@babel/typescript', 'minify'], | |||
| presets: [ | |||
| ['next/babel', { 'transform-runtime': { corejs: false } }], | |||
There was a problem hiding this comment.
Thanks @ykzts. Sorry I haven't had a chance to read up on this just yet. Would you consider this a breaking change? Will it affect older browsers for example on the current version of next?
I will look at getting this released this evening after work.
There was a problem hiding this comment.
The only difference is whether or not core-js is used. It does not affect older browsers or previous versions of Next.js.
|
@all-contributors please add @ykzts code |
|
I've put up a pull request to add @ykzts! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s):
Change
next/babeloptions and don't use@babel/runtime-corejs2. This will allow you to build Next.js v9.2.3 without any problems.Resolve #178