Add Video JSON-LD #547
Merged
Add Video JSON-LD #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmeeh
requested changes
Oct 26, 2020
There was a problem hiding this comment.
Hey @valse thanks for the contribution 💪
I haven't had a chance to review just yet, but I think it would be better to leave the import order as is for now. If you could revert any white space and re-ordering changes it will help me with the review.
|
@all-contributors please add @valse code doc |
|
I've put up a pull request to add @valse! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #533
Added the video json-ld component (https://developers.google.com/search/docs/data-types/video)
Replaced the recipe video object with this unique one.
Replaced the
http://schema.orgcontext with the https versionSorted the typescript imports (https://marketplace.visualstudio.com/items?itemName=mike-co.import-sorter)
Have updated the docs in the README