WIP ✨ Add og:video:secure_url and og:video:type #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmeeh
reviewed
Oct 31, 2020
There was a problem hiding this comment.
Thanks for the PR @TomPradat. It's looking good. If you want to just add these new properties to docs that would be great.
If you could also add a check in seo.spec.js in the test below:
it('SEO overrides apply correctly', () => {
You should see some examples in there, let me know if its not clear and I can lend a hand.
|
@TomPradat I see this PR hasn't been updated for 2 months. I can help you in updating the tests and documentation. |
|
Yeap sorry, I had a busy end of year and then honestly forgot about it. I'll work on this 👍 |
|
@all-contributors please add @TomPradat code |
|
I've put up a pull request to add @TomPradat! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s):
Fix #347
Some things to help get a PR reviewed and merged faster:
Not yet
I couldn't find tests about
og:video. Should i write some ? Maybe in another PR ?Same than above