-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a defaultTitle config option #598
Conversation
This change causes a `<title>` tag to be rendered if no `config.title` is provided but a `config.defaultTitle` is. It skips the templating step and renders the `defaultTitle` as is.
Code looks good @trevorblades thanks for the contribution👌 Would you be able to add to the documentation and I will get this merged and released. |
Done @garmeeh 👍 |
@all-contributors add @trevorblades doc code test |
I've put up a pull request to add @trevorblades! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Thanks for the contribution 🙌
This change causes a
<title>
tag to be rendered if noconfig.title
is provided but aconfig.defaultTitle
is. It skips the templating step and renders thedefaultTitle
as is.Fixes #366