Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing offers field in aggregateOffer #769

Merged
merged 10 commits into from
Jun 18, 2021

Conversation

hsynlms
Copy link
Contributor

@hsynlms hsynlms commented May 31, 2021

Closes: #766.

Description of Change(s):

  • New test to check if both offers and aggregateOffer are provided in product ld-json, the aggregateOffer is ignored.
  • New test to check product ld-json aggregateOffer separately
  • New test to check product ld-json offers separately
  • This PR also includes a fix of not set fields show up which are images and manufacturer in product ld-json in the output.

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Thank you! Love the new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offers is a missing field in AggregateOffer
2 participants