Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Event Source put-bucket-notification-configuration call overwrites any pre-existing notification configuration #88

Closed
olabhrad opened this issue Sep 8, 2016 · 1 comment
Closed

S3 Event Source put-bucket-notification-configuration call overwrites any pre-existing notification configuration #88

olabhrad opened this issue Sep 8, 2016 · 1 comment

Comments

@olabhrad
Copy link

olabhrad commented Sep 8, 2016

The S3 event source add function sends a new "LambdaFunctionConfigurations" array in the json block on it's "put_bucket_notification_configuration". This overwrites any existing elements that may already be in this array in the existing configuration. The method should check first to see if there are already elements, and then add a new element.
@olabhrad olabhrad changed the title S3 Event Source put-bucket-notification-configuration call overwrites any pre-existing notification-configuration S3 Event Source put-bucket-notification-configuration call overwrites any pre-existing notification configuration Sep 8, 2016
@olabhrad
Copy link
Author

olabhrad commented Sep 9, 2016

PR: #86

This was referenced Sep 9, 2016
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olabhrad