Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Event Source delete function not working as expected #89

Closed
olabhrad opened this issue Sep 9, 2016 · 1 comment
Closed

S3 Event Source delete function not working as expected #89

olabhrad opened this issue Sep 9, 2016 · 1 comment

Comments

@olabhrad
Copy link

olabhrad commented Sep 9, 2016

The S3 Event Source delete function is not working as expected. This is tangentially related to issue #88. The delete function expects that only one notification has been set up. It checks the first entry in"CloudFunctionConfiguration" to see if the function arn matches. If it does, it removes the whole "CloudFunctionConfiguration" block.

This in incorrect for two reasons:

  • If a different notification has been set up and appears before the expected notification, the expected notification will not be deleted.
  • If a different notification has been set up and appears after the expected notification, the expected notification and the other notification will both be deleted.

EDIT:
It's not that the code checks for the first entry in "CloudFunctionConfiguration" it's that it uses the deprecated get-bucket-notification which only returns the first notification. The result is still the same.

@olabhrad
Copy link
Author

olabhrad commented Sep 9, 2016

PR: #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant