Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded excluded_dirs #93

Closed
scottbouma opened this issue Oct 3, 2016 · 3 comments
Closed

Hard-coded excluded_dirs #93

scottbouma opened this issue Oct 3, 2016 · 3 comments

Comments

@scottbouma
Copy link

function.py hard-codes 8 directories that will always be excluded. But this breaks deployment of any projects that happen to use those packages. I discovered this when the "jmespath" dependency in my project mysteriously refused to be included in the deployed package. Some code-spelunking revealed the hard-coded list in function.py.

Any chance of just removing that list entirely? As far as I can tell kappa is not caching any of those dependencies in my src folder anyway, so I don't think it should need to exclude them.

@kapilt
Copy link

kapilt commented Jan 9, 2017

there builtins on the py lambda execution environment which has the boto3 sdk installed.

@stonemary
Copy link

+1
Would prefer them to be configurable. We might want to use a specific version of boto or other libraries such that code do not break when AWS change their execution environment.

@stonemary
Copy link

I will push a PR for them to be configurable.

josegonzalez added a commit that referenced this issue Feb 20, 2017
Add excluded_dirs support, add s3transfer excluded_dirs, fix #93 #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants