Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError at S3 file retrieval #68

Open
I159 opened this issue Jul 23, 2018 · 1 comment
Open

TypeError at S3 file retrieval #68

I159 opened this issue Jul 23, 2018 · 1 comment

Comments

@I159
Copy link

I159 commented Jul 23, 2018

During boto3.resource('s3').Object(bucket, key).get() TypeError raised and invalid json is recorded, while a response is totally valid. bytes type is not json serializable. And response body is a file which is of bytes type. But this is not a reason to raise an error and record invalid json. I propose to stub body with empty value and finish recording without error because lack of file is not an issue for unit testing but invalid record is.

@I159
Copy link
Author

I159 commented Jul 23, 2018

A PR to discuss #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant