Binary body recording #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I159
force-pushed
the
binary_body_recording
branch
5 times, most recently
from
757d03e
to
4aae96b
Compare
During recording a S3 object retrieving request the library raises `TypeError` while the response is totally valid. Response json data is copied including streaming body to handle potential issues with binary data without affecting original binary payload.
I159
force-pushed
the
binary_body_recording
branch
from
4aae96b
to
154174b
Compare
I159
force-pushed
the
binary_body_recording
branch
from
23670ec
to
7b1fc1f
Compare
I159
force-pushed
the
binary_body_recording
branch
from
7b1fc1f
to
901dd26
Compare
I159
force-pushed
the
binary_body_recording
branch
from
c8f853b
to
0616d35
Compare
I159
force-pushed
the
binary_body_recording
branch
from
0616d35
to
2a595c8
Compare
|
@garnaat We started hitting this issue too. Could this PR be merged? |
|
There are some merge conflicts at the moment. If the author wants to resolve those, that would be great. Otherwise I can do it and get it merged. |
|
+1 just ran into this error too. Would be great if you could merge |
Another +1 to the mix, ran into this while recording a session that pulls a file from S3. |
|
+1 running into this issue to with AppConfig. |
garnaat
pushed a commit
that referenced
this pull request
Sep 24, 2021
Merged
garnaat
added a commit
that referenced
this pull request
Sep 27, 2021
* Updating supported Python versions * Trying another approach to fix PR #70. * Removing caveman debug print statements. Co-authored-by: Mitch Garnaat <garnaat@amazon.com>
|
This should be fixed with a different approach in #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During recording a S3 object retrieving request the library raises TypeError while the response is totally valid and changing actual response, thus request couldn't be finished.