Add support for pickle serialization #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. This looks really good. I'm going to do some local testing. It seems like we would want to add some tests, especially around the selection of the right serializer when playing back. |
|
Is there any chance to get this merged? Would be awesome to be able to have tests for interactions with S3 and Lambda Invoke. Love Placebo. Thanks for all the work so far. |
|
I'll pull and test this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I found several problems serializing complex data in JSON documents, as described in #48 #45 and with others types like Dynamodb Binary or Decimal data. I added an option to use pickle to store the responses instead of JSON documents.
Recording the responses in pickle format fixes all the complex types serialization issues.
The playback mode will look for the recorded responses in any of the supported formats, so you can use a mixed solution with JSON and pickle formats for different responses. All the previous generated JSON documents will be valid.