add support for search by artist #1
Conversation
|
Hey Patrick, This is looking pretty good! You actually showed me how easy it is to add other search types to module. Not too shabby. Thanks for taking the time to do so. There's only one line in your request that I think I will remove: console.dir(). I like to keep the code absent of log messages. I have to thank you for exposing me to console.dir(). I just googled that and it seems pretty useful! |
|
Yikes! didnt notice I left that in there. I was reversing some of what you did before I realized you had the raw attribute available. Cheers |
|
I am testing your branch now. I thought that the package require call for Artist looked suspicious, and now I see that when I run "vows tests/*" it fails saying that it can't find the artist class. Did you add that file but not include it in the submit? |
| @@ -7,6 +7,7 @@ | |||
| require.paths.unshift(require('path').join(__dirname,'./util')); | |||
|
|
|||
| var Album = require('album').Album; | |||
| var Artist = require('artist').Artist; | |||
There was a problem hiding this comment.
Where is the Artist class definition?
There was a problem hiding this comment.
just pushed.
|
Just published as version 0.0.3 :) Enjoy and thanks for contributing! |
real quick hack to add support searching by artist name. Its needed by a project im working on, and I would really like for it to be in the npm'ed version of this.