Router: update history package to 5.3.0, fix query string generation (W…

…ordPress#60271) Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
garridinsi · Apr 9, 2024 · 6eb6c09 · 6eb6c09
1 parent 0e72702
commit 6eb6c09
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 16 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/router/package.json b/packages/router/package.json
@@ -29,7 +29,7 @@
 		"@wordpress/element": "file:../element",
 		"@wordpress/private-apis": "file:../private-apis",
 		"@wordpress/url": "file:../url",
-		"history": "^5.1.0"
+		"history": "^5.3.0"
 	},
 	"peerDependencies": {
 		"react": "^18.0.0"

diff --git a/packages/router/src/history.js b/packages/router/src/history.js
@@ -13,18 +13,13 @@ const history = createBrowserHistory();
 const originalHistoryPush = history.push;
 const originalHistoryReplace = history.replace;
 
-function buildSearch( params ) {
-	const queryString = buildQueryString( params );
-	return queryString.length > 0 ? '?' + queryString : queryString;
-}
-
 function push( params, state ) {
-	const search = buildSearch( params );
+	const search = buildQueryString( params );
 	return originalHistoryPush.call( history, { search }, state );
 }
 
 function replace( params, state ) {
-	const search = buildSearch( params );
+	const search = buildQueryString( params );
 	return originalHistoryReplace.call( history, { search }, state );
 }