Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move lablgtk2 examples into a subdirectory in the lablgtk3 branch #81

Open
martindemello opened this issue Aug 30, 2019 · 3 comments
Open

move lablgtk2 examples into a subdirectory in the lablgtk3 branch #81

martindemello opened this issue Aug 30, 2019 · 3 comments
Labels
gtk3 Issue on the lablgtk3 branch

Comments

@martindemello
Copy link
Contributor

It is currently unclear which examples have been updated to gtk3. Moving everything into a gtk2/ subdirectory and then copying them back as they are updated would both make things easier to find, and be a valuable guide to updating code (since we could then diff foo.ml gtk2/foo.ml to see what changed between 2 and 3).

I'd be happy to do this if people think it's a good idea.
@XVilka
Copy link
Contributor

XVilka commented Aug 30, 2019 •
edited
Loading

See also #4, and #66

@garrigue
Copy link
Owner

I'm fine with that approach (sorry for the delay)

@garrigue garrigue added the gtk3 Issue on the lablgtk3 branch label Nov 25, 2019
@ejgallego
Copy link
Collaborator

The dune file has the non-working examples commented out; that could also work tho indeed not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gtk3 Issue on the lablgtk3 branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martindemello @XVilka @garrigue @ejgallego