Add support for inline_mode #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need this 👍 |
|
Any progress here? It would be very nice to have this! |
|
Thank you for the contribution! I'll merge this and clean up the tests 👍 |
garriguv
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the inline_mode in a similar way it's done in the SwiftLint plugin.
SwiftFormat now also supports JSON reporting, which would remove the need to parse the details from the string, but that looks like it would require a lot more changes.
I can also add some tests for this, if you point me to start as I'm not very familiar with how ruby works and have no idea how to access some of the data. E.g. this in danger-swiftLint repo: