Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/code inspections #1350

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Feature/code inspections #1350

merged 4 commits into from
Aug 11, 2021

Conversation

klodoma
Copy link
Contributor

@klodoma klodoma commented Aug 10, 2021

Changes:

  • run idea64 code inspection
  • reformat code with eslint
  • convert var to const/let

This is only about code formatting, getting rid of several warnings in the editor.

I haven't checked all of them, first I would like to get a feedback if this direction is OK or NOT.

@conradkirschner
Copy link
Contributor

I would like to see that in the next major version, maybe also with some git hooks implemented to force codestyle.

For my pullrequest I tried to keep the current code-style, to make it easier to merge/read...
#1342

Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- nice cleanup work!

@garris garris merged commit c0dde94 into garris:master Aug 11, 2021
@klodoma klodoma deleted the feature/code-inspections branch August 12, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants