Rollback docker user change #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tkrah
commented
Apr 19, 2023
tkrah
commented
- defaults to root now again
- added a recommendation to the README.md to configure a more appropriate user to run the test by changing the dockerCommandTemplate config option
- fixes (Failing to create bitmaps_test folder in GitHub Actions after upgrade to 6.2.0 #1466)
|
@garris That would be my proposal like discussed - nothing better came to my mind to honor your expectations ;-) |
- defaults to root now again - added a recommendation to the README.md to configure a more appropriate user to run the test by changing the dockerCommandTemplate config option - fixes (garris#1466)
tkrah
force-pushed
the
feature/revert-default-user
branch
from
b825b3b
to
fde03f4
Compare
|
@garris this looks like the fix to something I was running into but it doesn't seem to have made its way into a tagged release on over to docker hub. any changes you could do that? |
|
Will look at this today |
|
Yup -- looks like the last publish clearly didn't work. Just pushed a new version please LMK if it's not working as expected. Cheers. |
|
Looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.