Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variables in comparison expressions are not converted #108

Closed
dancrumb opened this issue Jun 13, 2023 · 1 comment · Fixed by #109
Closed

Environment variables in comparison expressions are not converted #108

dancrumb opened this issue Jun 13, 2023 · 1 comment · Fixed by #109
Assignees
@dancrumb

Comments

@dancrumb
Copy link
Collaborator

dancrumb commented Jun 13, 2023 •
edited
Loading

Expressions like process.env.BUF_BIGINT_DISABLE !== "1" are not converted via the current implementation

In addition, the test case noted here should be addressed.
@dancrumb dancrumb self-assigned this Jun 13, 2023
@dancrumb dancrumb mentioned this issue Jun 13, 2023
Merged
@dancrumb
Copy link
Collaborator Author

It's possible that the current conversion approach can be greatly simplified by just importing node: process... I'll look into it

dancrumb added a commit to dancrumb/denoify that referenced this issue Jun 14, 2023
@dancrumb
fix(builtins): import node:process if process is used
e3a68ce 
Fixes garronej#108
@dancrumb dancrumb mentioned this issue Jun 14, 2023
Merged
garronej added a commit to dancrumb/denoify that referenced this issue Jun 15, 2023
@garronej
Merge branch 'main' into fix/garronej#108
d2219de
garronej added a commit that referenced this issue Jun 15, 2023
@garronej
Merge pull request #109 from dancrumb/fix/#108
974e684 
Import `node:process` if `process` is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancrumb dancrumb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import node:process if process is used dancrumb/denoify
2 participants
@dancrumb @garronej