Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node builtin modules with partial support can't be overridden with replacer or ports options #53

Closed
josh-hemphill opened this issue Aug 9, 2022 · 2 comments

Comments

@josh-hemphill
Copy link

josh-hemphill commented Aug 9, 2022

It looks like I'm getting node modules being replaced with DENOIFY: DEPENDENCY UNMET (BUILTIN), is there a config I'm missing to be able to set those to use the incomplete deno_std compat shims?
The README says these were supported in v0.11, but if I add an import dns from 'dns' to the demo repo with the updated denoify, with or without a manual port/replacement, it always generates import dns from 'dns DENOIFY: DEPENDENCY UNMET (BUILTIN)'.

My last update to my fork of the example repo contains an reproduction of this as well: https://github.com/josh-hemphill/my_dummy_npm_and_deno_module

@josh-hemphill josh-hemphill changed the title Node modules with partial support can't be overridden with replacer or ports options Node builtin modules with partial support can't be overridden with replacer or ports options Aug 9, 2022
@garronej
Copy link
Owner

I can reproduce, thanks for reporting, fixing.

garronej added a commit that referenced this issue Aug 10, 2022
@garronej
Copy link
Owner

@josh-hemphill, it's fixed... eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants