feat(config-file): provide support for config file #62
Conversation
|
Also it would be realy nice to write some doc for the available config on https://docs.denoify.land like I have done with https://docs.keycloakify.dev/build-options. |
Can you resend it to me? I dont think I have the invitation for the GitBook |
|
@GervinFung LGTM! Thanks for applying my suggesting and refactorying! |
Just to confirm that there is nothing left to resolve right? If that's the case, I will fix the merging issues and merge it if you are ok with it |
Yes alright, let's release in beta first to make sure nothing've been broken and until there is some documentation for it. So just fix the conflict and update the |
…ly created before storing it
…mmented test file
| import { ModuleAddress } from "../../../lib/types/ModuleAddress"; | ||
| import { assert } from "tsafe"; | ||
| import { getValidImportUrlFactory } from "../../../lib/resolveNodeModuleToDenoModule"; | ||
|
|
||
| (async () => { | ||
| const userOrOrg = "GervinFung"; | ||
| const moduleAddress: ModuleAddress.GitHubRepo = { | ||
| "type": "GITHUB REPO", | ||
| userOrOrg, | ||
| "repositoryName": "my_dummy_npm_and_deno_module", | ||
| "branch": "master" | ||
| }; | ||
|
|
||
| { | ||
| const getValidImportUrlFactoryResult = await getValidImportUrlFactory({ | ||
| moduleAddress, | ||
| "desc": "NOT LISTED AS A DEPENDENCY (PROBABLY NODE BUILTIN)" | ||
| }); | ||
|
|
||
| assert(getValidImportUrlFactoryResult.couldConnect === true); | ||
|
|
||
| assert(getValidImportUrlFactoryResult.versionFallbackWarning === undefined); | ||
|
|
||
| assert( | ||
| (await getValidImportUrlFactoryResult.getValidImportUrl({ "target": "DEFAULT EXPORT" })) === | ||
| `https://raw.githubusercontent.com/${userOrOrg}/my_dummy_npm_and_deno_module/master/deno_dist/mod.ts` | ||
| ); | ||
| assert( | ||
| (await getValidImportUrlFactoryResult.getValidImportUrl({ "target": "SPECIFIC FILE", "specificImportPath": "dist/lib/Cat" })) === | ||
| `https://raw.githubusercontent.com/${userOrOrg}/my_dummy_npm_and_deno_module/master/deno_dist/lib/Cat.ts` | ||
| ); | ||
| } | ||
|
|
||
| console.log("PASS"); | ||
| })(); |
There was a problem hiding this comment.
This test is a very good idea!
A couple of thing I would like to be addressed:
- Could you create an other fork and an other test (13) where your config file would have an explicite a out parameter to make sure that your file is wel parsed.
- Create a GitHub release for your forks, and use:
"desc": "MATCH VERSION INSTALLED IN NODE_MODULES",
"version": "v1.0.0"instead of NOT LISTED AS A DEPENDENCY (PROBABLY NODE BUILTIN), it's a bit confusing, it make it hard to understand what we are testing.
Thank you very much!
This PR is to resolve the issues stated in #55