Fixed face poser not posing the last flex on some models #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NO-LOAFING
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Face Poser's think function subtracts 1 from the flex count for no reason, making it skip the last flex when applying the values from the convars. Usually, this doesn't matter, since on most models, the last flex is a useless internal thing like a gesture or eye movement flex that the tool would just ignore anyway. On a few models, though, like the TF2 Engineer (both standard and HWM), the last flex isn't useless, but the slider for it in the cpanel doesn't do anything since the think function never applies its value to the model.