Fixed some backwards compatibility issues with #1141 #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is what I currently have, but it has one major downside - what if the skin does not have that variable? |
|
It falls back to the default skin. https://github.com/garrynewman/garrysmod/blob/master/garrysmod/lua/derma/derma.lua#L35-L37 |
|
Though even if it didn't, the behaviour would be the same as before the update (SetTextColor was called in the SKIN - would've been nil otherwise). |
|
Was not aware of that fallback stuff, I suppose this fix works then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best fix I could think of.