net.ReadType no longer requires an argument #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've never understood why this wasn't default behaviour. I guess some people want to manually grab the typeid to store it or something? |
|
It definitely makes no sense as it is seeing as WriteType doesn't take the TypeID as a parameter. Either way, this PR keeps backwards-compatibility. |
This makes it actually make sense to use, but also keeps backwards compatibility to help any poor soul who has used it anyway.
|
Updated to make this merge-able after #798. |
robotboy655
added a commit
that referenced
this pull request
Mar 26, 2015
net.ReadType no longer requires an argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it actually make sense to use, but also keeps backwards compatibility to help any poor soul who has used it anyway.
Also updates net.WriteTable and net.ReadTable to use it, which makes them a bit easier to understand.