net.ReadType no longer requires an argument #821

Merged
merged 1 commit into from Mar 26, 2015

Projects

None yet

4 participants

@willox
Collaborator
willox commented Sep 29, 2014

This makes it actually make sense to use, but also keeps backwards compatibility to help any poor soul who has used it anyway.

Also updates net.WriteTable and net.ReadTable to use it, which makes them a bit easier to understand.

@willox willox closed this Oct 1, 2014
@willox willox deleted the unknown repository branch Oct 1, 2014
@willox willox restored the unknown repository branch Oct 1, 2014
@willox willox reopened this Oct 1, 2014
@MattJeanes

I've never understood why this wasn't default behaviour. I guess some people want to manually grab the typeid to store it or something?

@willox
Collaborator
willox commented Oct 14, 2014

It definitely makes no sense as it is seeing as WriteType doesn't take the TypeID as a parameter. Either way, this PR keeps backwards-compatibility.

@willox willox net.ReadType no longer requires an argument
This makes it actually make sense to use, but also keeps backwards
compatibility to help any poor soul who has used it anyway.
aae1ee3
@willox
Collaborator
willox commented Mar 26, 2015

Updated to make this merge-able after #798.

@robotboy655 robotboy655 merged commit 0b82457 into garrynewman:master Mar 26, 2015
@willox willox deleted the unknown repository branch Mar 26, 2015
@comedinha
Contributor

Couldn't include file 'extensions\net.lua' (File not found) (@lua/includes/init.lua (line 10))
Back to require and work again

Collaborator

send.txt was not updated (it should have been done in #798)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment