Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to listener count might force layout in some situations #8

Closed
garthenweb opened this issue Jul 23, 2019 · 1 comment
Closed

update to listener count might force layout in some situations #8

garthenweb opened this issue Jul 23, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@garthenweb
Copy link
Owner

Screenshot 2019-07-23 at 10 28 59

This is unintended as it should not trigger layout immediately but in the next frame if required. Maybe there are possible performance improvements.
@garthenweb garthenweb added bug Something isn't working enhancement New feature or request labels Jul 23, 2019
@garthenweb
Copy link
Owner Author

Fixed with 46d3632

garthenweb added a commit that referenced this issue Sep 1, 2019
@garthenweb
fix(hooks): don't cause forced updates
b5f5a5b 
On mount the useLayoutSnapshot hook performed an update
which caused a forced layout. By scheduling this event
via the normal listener update this will cause less layout trashing.

Fixes #8
garthenweb added a commit that referenced this issue Sep 1, 2019
@garthenweb
fix(hooks): don't cause forced updates
0b322d4 
On mount the useLayoutSnapshot hook performed an update
which caused a forced layout. By scheduling this event
via the normal listener update this will cause less layout trashing.

Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garthenweb