Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Take into account currently used color theme for rendering entities in the 2D view. #149

Closed
RazielZnot opened this issue Sep 10, 2023 · 6 comments

Comments

@RazielZnot
Copy link

I always use Black and Green theme but it has one issue, using func_group or some other entities colored as black makes their wireframe invisible in the 2D view which is very annoying. I understand that this color is set in the DEF file but the editor shouldn't use it straight away, at least turn it negative or something?

@Garux
Copy link
Owner

Garux commented Sep 13, 2023

I think it's up to ent def composer to not use black color, which collides with world while white bg and bg while dark bg.
If we automatically alter colors, they will likely collide something else, e.g. entity or grid; And entity color inconsistency is not cool in general.

@RazielZnot
Copy link
Author

The problem is that the average user doesn't know about such details. Back in the day, when I only started using GtkRadiant, I had no idea why Black and Green theme makes some entities invisible, so I had no other choice but to switch between themes, which defeats the purpose of having them. Comparing the color of the entity to the current color of the background shouldn't be an issue, if the background is black and the entity is black then turn the entity negative, or turn them all negative without comparison just check which theme is currently in use, then black will turn white, orange - blue, red - cyan, it will look fine on black background.

@Garux
Copy link
Owner

Garux commented Sep 13, 2023

I have just explained why this is not optimal idea. Let's fix those .defs instead to improve UX.

@RazielZnot
Copy link
Author

Most users have no idea how to edit the DEF file, this is the point and I don't care about my own convenience here. I may fix it for myself, but what about the rest of the users? If the editor requires manual editing of the DEF file, then I see this as a design flaw of the editor, because it looks just fine when used with the default color theme.

@Garux
Copy link
Owner

Garux commented Sep 13, 2023

Fix for yourself and share, so i'll include it for others.

@RazielZnot RazielZnot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
@RazielZnot
Copy link
Author

Too many of them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants