Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grok support matrix? #10

Open
synhershko opened this issue Dec 4, 2015 · 3 comments
Open

grok support matrix? #10

synhershko opened this issue Dec 4, 2015 · 3 comments

Comments

@synhershko
Copy link

What is the feature parity between pygrok and the original logstash grok?

If full, this should be written somehow (and have tests to prove..).

If partial, can you please add a support matrix, so it's clear to users what's supported and what's not, and also so it's easier to contribute back?

@garyelephant
Copy link
Owner

This is a good idea.

As far as I remember, pygrok and logstash grok are almost the same in functionality exept that pygrok don't have data type conversion.For example:
%{NUMBER:num:int} in logstash grok will convert num to integer in json eventally, but pygrok don't support this kind of syntax.

@synhershko
Copy link
Author

I'm doing some work on this area now and will probably need to improve on feature parity and performance. I'm hoping you accept PRs? :)

The patterns folder isn't up to date - I was thinking of using a git submodule to have it point to the official folder at https://github.com/logstash-plugins/logstash-patterns-core instead of duplicating it here like it is now.

As far as the syntax goes - any particular reason data type conversion isn't supported?

@garyelephant
Copy link
Owner

I just have no enough time to implement data type conversion, feel free to make a pull request.
I have to duplicate the patterns folder because pygrok is managed by pip and logstash-patterns-core is managed by rubygems, so it's not easy to get those default patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants